chore: add tests and refactor null check

Signed-off-by: Ruben Romero Montes <[email protected]>

Author: ruromero

src/main/java/com/redhat/exhort/api/PackageRef.java

@@ -52,19 +52,13 @@ public PackageURL purl() {
   }
 
   public String name() {
+    if (purl.getNamespace() == null) {
+      return purl.getName();
+    }
     switch (purl.getType()) {
       case Constants.GOLANG_PKG_MANAGER:
-        if (purl().getNamespace() != null) {
-          return new StringBuffer(purl.getNamespace())
-              .append("/")
-              .append(purl.getName())
-              .toString();
-        }
-        return purl.getName();
+        return new StringBuffer(purl.getNamespace()).append("/").append(purl.getName()).toString();
       default:
-        if (purl.getNamespace() == null) {
-          return purl.getName();
-        }
         return new StringBuilder(purl.getNamespace()).append(":").append(purl.getName()).toString();
     }
   }

src/test/java/com/redhat/exhort/api/PackageRefTest.java

@@ -0,0 +1,53 @@
+/*
+ * Copyright 2023 Red Hat, Inc. and/or its affiliates
+ * and other contributors as indicated by the @author tags.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.redhat.exhort.api;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+import org.junit.jupiter.api.Test;
+
+public class PackageRefTest {
+
+  @Test
+  public void testNamespace() {
+    PackageRef ref =
+        new PackageRef("pkg:golang/google.golang.org/genproto#googleapis/api/annotations");
+    assertEquals("google.golang.org/genproto", ref.name());
+
+    ref = new PackageRef("pkg:golang/[email protected]");
+    assertEquals("go.opencensus.io", ref.name());
+
+    ref = new PackageRef("pkg:npm/[email protected]");
+    assertEquals("foobar", ref.name());
+
+    ref = new PackageRef("pkg:maven/org.apache.xmlgraphics/[email protected]?packaging=sources");
+    assertEquals("org.apache.xmlgraphics:batik-anim", ref.name());
+  }
+
+  @Test
+  public void testVersion() {
+    PackageRef ref =
+        new PackageRef("pkg:golang/google.golang.org/genproto#googleapis/api/annotations");
+    assertNull(ref.version());
+
+    ref = new PackageRef("pkg:golang/[email protected]");
+    assertEquals("v0.21.0", ref.version());
+  }
+}