Skip to content

Commit 8275958

Browse files
committed
apply review feedback
1 parent d06623d commit 8275958

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ answers any questions you may have.
88

99
We use GitHub issues to track public bugs and requests. Please ensure your bug
1010
description is clear and has sufficient instructions to be able to reproduce the
11-
issue. The best way is to add a failing test to our test suite via a pull request.
11+
issue. The absolute best way to do that is to add a failing test to our test suite via a pull request, but a reduced test case on a site like [StackBlitz](https://stackblitz.com/) or [CodeSandbox](https://codesandbox.io/) is also very helpful.
1212

1313
## Pull Requests
1414

@@ -20,8 +20,8 @@ your [pull requests](https://help.github.com/articles/creating-a-pull-request).
2020
Since graphql-js is a reference implementation of the
2121
[GraphQL spec](https://graphql.github.io/graphql-spec/), only changes which comply
2222
with this spec will be considered. If you have a change in mind which requires a
23-
change to the spec, please consider opening instead an
24-
[issue](https://github.com/graphql/graphql-spec/issues/) against the spec and/or attending a [GraphQL Working Group meeting](https://github.com/graphql/graphql-wg) to discuss your proposal. See the [contribution guide for the specification](https://github.com/graphql/graphql-spec/blob/main/CONTRIBUTING.md) for further information. Stage 1 and 2 proposals may be implemented within graphql-js behind a feature flag.
23+
change to the spec, please consider opening an
24+
[issue](https://github.com/graphql/graphql-spec/issues/) against the spec and/or attending a [GraphQL Working Group meeting](https://github.com/graphql/graphql-wg) to discuss your proposed change. See the [contribution guide of the specification](https://github.com/graphql/graphql-spec/blob/main/CONTRIBUTING.md) for further information. Stage 1 and 2 proposals may be implemented within graphql-js behind a feature flag.
2525

2626
### GraphQL Specification Membership Agreement
2727

@@ -78,7 +78,7 @@ ensure your pull request matches the style guides, run `npm run prettier`.
7878
- Pull requests are required to pass all tests and checks before they can be merged.
7979
- Ideally, pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they are merged, preferably from separate organizations. For more complex pull requests, a larger cohort of reviewers is suggested.
8080
- Any reviewer may request that the topic be brought for more in depth discussion at a [GraphQL JS Working Group meeting](https://github.com/graphql/graphql-js-wg/), where decisions will be made by consensus.
81-
- A PR that has been merged without discussion at a GraphQL JS Working Group meeting may be reverted if a more in depth discussion is later requested.
81+
- A PR that has been merged without discussion at a GraphQL JS Working Group meeting can be revisited in any subsequent meeting; the PR may be reverted as a result of that discussion.
8282

8383
## Discussion
8484

0 commit comments

Comments
 (0)