[new ui] Toolbar component #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=======================================
Coverage 53.73% 53.73%
=======================================
Files 76 76
Lines 3413 3413
Branches 650 650
=======================================
Hits 1834 1834
Misses 1361 1361
Partials 218 218Continue to review full report at Codecov.
|
|
ah! i see what you've done here. looks very nice |
acao
reviewed
Jan 8, 2020
| import PropTypes from 'prop-types'; | ||
|
|
||
| const ListRow = ({ children, flex = false, padding = true }) => ( | ||
| const ListRow = ({ children, flex = false, padding = false }) => ( |
There was a problem hiding this comment.
i like making padding explicit, excellent idea
There was a problem hiding this comment.
i'm a bit conflicted bc ideally itll always be the children of listrow that have padding but it comes in super handy for storybook bc it's mostly text blocks if that makes sense?
|
hold up why are the tabs listed twice on storybook will have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
<Toolbar />component to wrap elements like tabbars🌈 Demo 🌈
Screenshots