Skip to content

Conversation

acao
Copy link
Member

@acao acao commented Dec 12, 2019

originally by @PascalSenn in graphql/graphql-language-service#220

  • fixes Mode graphql failed to advance stream further down in the LSP
  • same bug we worked around in GraphiQL or graphql-cm? months ago.
  • resolves the issue at the LSP level (parser), for both server/browser contexts

originally by @PascalSenn in graphql/graphql-language-service#220

- fixes `Mode graphql failed to advance stream` upstream
- same bug we worked around in GraphiQL or graphql-cm? months ago.
- still impacts the whole LSP

Created-By: @PascalSenn
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1091 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   43.85%   43.85%           
=======================================
  Files          65       65           
  Lines        3001     3001           
  Branches      650      650           
=======================================
  Hits         1316     1316           
  Misses       1414     1414           
  Partials      271      271
Impacted Files Coverage Δ
...kages/graphql-language-service-parser/src/Rules.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cec0a...00348ee. Read the comment docs.

@acao acao merged commit 91763dd into master Dec 18, 2019
@acao acao deleted the fix/gls-cleanup-nb-whitespace branch December 28, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant