chore: Upgrade to ocaml 5, binaryen.ml 0.27.0 #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
added
the
admin
spotandjake
force-pushed
the
spotandjake-clang-17
branch
from
5f7f102 to
618e733
Compare
spotandjake
changed the title
spotandjake
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair and
phated
as code owners
|
@hhugo Pinging as I know you were waiting for the jsoo update included in this pr. |
ospencer
approved these changes
Oct 29, 2025
spotandjake
changed the title
ospencer
changed the title
spotandjake
commented
Oct 29, 2025
|
|
||
| let setup_colors = () => | ||
| Misc.Color.setup @@ | ||
| Misc.Style.setup @@ |
There was a problem hiding this comment.
Small code change do to an api change.
| let buf = Buffer.create(64); | ||
| let ppf = Format.formatter_of_buffer(buf); | ||
| Misc.Color.set_color_tag_handling(ppf); | ||
| Misc.Style.set_tag_handling(ppf); |
There was a problem hiding this comment.
Small code change do to an api change.
| "smallest_grain_program", | ||
| "", | ||
| 6503, | ||
| 6059, |
There was a problem hiding this comment.
Our smallest program size got reduced after upgrading to binaryen.ml, 0.27.0 as the optimizations were improved slightly.
marcusroberts
approved these changes
Oct 29, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a bunch of our downstream depencies moving us from
binaryen.ml,0.26.0to0.27.0along with ocaml 5.This also fixes building on the latest version of macos.
Closes: #2321
Resolves: #2255 and #1909