fix: set MaxBytes for AckQueue #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
commented
Sep 6, 2024
| @@ -99,36 +99,6 @@ class ModAckQueue extends messageTypes.ModAckQueue { | |||
| } | |||
| } | |||
|
|
|||
| // This discount polyfill for Promise.allSettled can be removed after we drop Node 12. | |||
There was a problem hiding this comment.
This and the related changes below are just cleanup I did while in here.
hongalex
reviewed
Sep 6, 2024
|
More info about the semver thing over here: googleapis/nodejs-bigquery-storage#475 |
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
hongalex
approved these changes
Sep 12, 2024
dermasmid
reviewed
Nov 12, 2024
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes this one: #1897
Thanks to @dermasmid for getting that started; I'm starting a new one to have write access for changes and CI.
This implements a fix to keep ack/modack batches under a size that the server can handle.
Fixes #1864