Skip to content

Conversation

@cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1077 ☕️

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners January 11, 2024 22:27
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 11, 2024
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Jan 11, 2024
@cindy-peng cindy-peng changed the title feat:add graal native image profile for logback library feat: add graal native image profile for logback library Jan 11, 2024
@cindy-peng cindy-peng self-assigned this Jan 11, 2024
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nit!

<profile>
<id>native</id>
<properties>
<test>!LoggingAppenderTest</test>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-add the comment that was in the build.sh file about why we're skipping this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-add the comment that was in the build.sh file about why we're skipping this

Good feedback! Added the comment.

@cindy-peng cindy-peng merged commit ab58b88 into main Jan 16, 2024
@cindy-peng cindy-peng deleted the cindy/native-profile branch January 16, 2024 22:41
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/java-logging-logback API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create "native" profile in pom to override default settings in shared config

2 participants