fix(AIP-136): support response msg lint with resource singular name #1499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
core::0136::response-message-name
rule uses a heursitic to verify and account for the target resource type being the response type of the custom method (rather than a message type that aligns with the RPC name). It did this by checking for aname
field with aresource_reference
annotation and comparing thetype
there to thetype
of agoogle.api.resource
annotation on the response to see if they matched. However, some AIPs recommend using a resource-singular-aligned field name in the request message e.g. the AIP-144 Add/Remove methods. So rather thanAddAuthor
, which returns aBook
, checking for aname
field, it will check for abook
field as well and use that allow the custom method response type to be aBook
rather thanAddAuthorResponse
.This still prefers
name
if present in addition to a resource-singular-aligned field.Internal bug http://b/424243407