feat: allow request_id for standard Get and List (#1312)

Author: Juneezee

docs/rules/0131/request-unknown-fields.md

@@ -19,6 +19,7 @@ This rule looks at any message matching `Get*Request` and complains if it comes
 across any fields other than:
 
 - `string name` ([AIP-131][])
+- `string request_id` ([AIP-155][])
 - `google.protobuf.FieldMask read_mask` ([AIP-157][])
 - `View view` ([AIP-157][])
 
@@ -62,5 +63,6 @@ If you need to violate this rule for an entire file, place the comment at the
 top of the file.
 
 [aip-131]: https://aip.dev/131
+[aip-155]: https://aip.dev/155
 [aip-157]: https://aip.dev/157
 [aip.dev/not-precedent]: https://aip.dev/not-precedent

docs/rules/0132/request-unknown-fields.md

@@ -25,6 +25,7 @@ comes across any fields other than:
 - `string filter` ([AIP-132][])
 - `string order_by` ([AIP-132][])
 - `bool show_deleted` ([AIP-132][])
+- `string request_id` ([AIP-155][])
 - `google.protobuf.FieldMask read_mask` ([AIP-157][])
 - `View view` ([AIP-157][])
 
@@ -79,6 +80,7 @@ top of the file.
 
 [aip-132]: https://aip.dev/132
 [aip-135]: https://aip.dev/135
+[aip-155]: https://aip.dev/155
 [aip-157]: https://aip.dev/157
 [aip-158]: https://aip.dev/158
 [aip.dev/not-precedent]: https://aip.dev/not-precedent

rules/aip0131/request_unknown_fields.go

@@ -24,14 +24,20 @@ import (
 	"github.com/jhump/protoreflect/desc"
 )
 
+var allowedFields = stringset.New(
+	"name",       // AIP-131
+	"request_id", // AIP-155
+	"read_mask",  // AIP-157
+	"view",       // AIP-157
+)
+
 // Get methods should not have unrecognized fields.
 var unknownFields = &lint.FieldRule{
 	Name: lint.NewRuleName(131, "request-unknown-fields"),
 	OnlyIf: func(f *desc.FieldDescriptor) bool {
 		return utils.IsGetRequestMessage(f.GetOwner())
 	},
 	LintField: func(field *desc.FieldDescriptor) []lint.Problem {
-		allowedFields := stringset.New("name", "read_mask", "view")
 		if !allowedFields.Contains(field.GetName()) {
 			return []lint.Problem{{
 				Message: fmt.Sprintf(

rules/aip0131/request_unknown_fields_test.go

@@ -38,6 +38,7 @@ func TestUnknownFields(t *testing.T) {
 		fieldType   *builder.FieldType
 		problems    testutils.Problems
 	}{
+		{"RequestId", "GetBookRequest", "request_id", builder.FieldTypeImportedMessage(fieldMask), testutils.Problems{}},
 		{"ReadMask", "GetBookRequest", "read_mask", builder.FieldTypeImportedMessage(fieldMask), testutils.Problems{}},
 		{"View", "GetBookRequest", "view", builder.FieldTypeEnum(builder.NewEnum("View").AddValue(builder.NewEnumValue("BASIC"))), testutils.Problems{}},
 		{"Invalid", "GetBookRequest", "application_id", builder.FieldTypeString(), testutils.Problems{{

rules/aip0132/request_unknown_fields.go

@@ -29,6 +29,7 @@ var allowedFields = stringset.New(
 	"filter",       // AIP-132
 	"order_by",     // AIP-132
 	"show_deleted", // AIP-135
+	"request_id",   // AIP-155
 	"read_mask",    // AIP-157
 	"view",         // AIP-157
 )

rules/aip0132/request_unknown_fields_test.go

@@ -44,6 +44,7 @@ func TestUnknownFields(t *testing.T) {
 		{"Filter", "ListBooksRequest", "filter", builder.FieldTypeString(), testutils.Problems{}},
 		{"OrderBy", "ListBooksRequest", "order_by", builder.FieldTypeString(), testutils.Problems{}},
 		{"ShowDeleted", "ListBooksRequest", "show_deleted", builder.FieldTypeBool(), testutils.Problems{}},
+		{"RequestId", "ListBooksRequest", "request_id", builder.FieldTypeImportedMessage(fieldMask), testutils.Problems{}},
 		{"ReadMask", "ListBooksRequest", "read_mask", builder.FieldTypeImportedMessage(fieldMask), testutils.Problems{}},
 		{"View", "ListBooksRequest", "view", builder.FieldTypeEnum(builder.NewEnum("View").AddValue(builder.NewEnumValue("BASIC"))), testutils.Problems{}},
 		{"Invalid", "ListBooksRequest", "application_id", builder.FieldTypeString(), testutils.Problems{{Message: "explicitly described"}}},