fix: Fix typos in AIP-231's http_uri_suffix rule (#610)

apasel422 · Luke Sneeringer · web-flow · commit 20b5ec14f108 · 2020-08-31T16:26:36.000-07:00
Co-authored-by: Luke Sneeringer &lt;lukesneeringer@google.com&gt;
diff --git a/rules/aip0231/http_uri_suffix.go b/rules/aip0231/http_uri_suffix.go
@@ -29,7 +29,7 @@ var uriSuffix = &lint.MethodRule{
 		for _, httpRule := range utils.GetHTTPRules(m) {
 			if !batchGetURINameRegexp.MatchString(httpRule.URI) {
 				return []lint.Problem{{
-					Message:    `Get methods URI should be end with ":batchGet".`,
+					Message:    `Batch Get method's URI should end with ":batchGet".`,
 					Descriptor: m,
 				}}
 			}
diff --git a/rules/aip0231/http_uri_suffix_test.go b/rules/aip0231/http_uri_suffix_test.go
@@ -32,7 +32,7 @@ func TestHttpUrl(t *testing.T) {
 		problems   testutils.Problems
 	}{
 		{"Valid", "/v1/{parent=publishers/*}/books:batchGet", "BatchGetBooks", nil},
-		{"InvalidVarName", "/v1/{parent=publishers/*}/books", "BatchGetBooks", testutils.Problems{{Message: `Get methods URI should be end with ":batchGet".`}}},
+		{"InvalidVarName", "/v1/{parent=publishers/*}/books", "BatchGetBooks", testutils.Problems{{Message: `Batch Get method's URI should end with ":batchGet".`}}},
 		{"Irrelevant", "/v1/{book=publishers/*/books/*}", "AcquireBook", nil},
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ var uriSuffix = &lint.MethodRule{`
`29`	`29`	`for _, httpRule := range utils.GetHTTPRules(m) {`
`30`	`30`	`if !batchGetURINameRegexp.MatchString(httpRule.URI) {`
`31`	`31`	`return []lint.Problem{{`
`32`		- Message: `Get methods URI should be end with ":batchGet".`,
	`32`	+ Message: `Batch Get method's URI should end with ":batchGet".`,
`33`	`33`	`Descriptor: m,`
`34`	`34`	`}}`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ func TestHttpUrl(t *testing.T) {`
`32`	`32`	`problems testutils.Problems`
`33`	`33`	`}{`
`34`	`34`	`{"Valid", "/v1/{parent=publishers/*}/books:batchGet", "BatchGetBooks", nil},`
`35`		- {"InvalidVarName", "/v1/{parent=publishers/*}/books", "BatchGetBooks", testutils.Problems{{Message: `Get methods URI should be end with ":batchGet".`}}},
	`35`	+ {"InvalidVarName", "/v1/{parent=publishers/*}/books", "BatchGetBooks", testutils.Problems{{Message: `Batch Get method's URI should end with ":batchGet".`}}},
`36`	`36`	`{"Irrelevant", "/v1/{book=publishers//books/}", "AcquireBook", nil},`
`37`	`37`	`}`
`38`	`38`