Skip to content

dashboard: more graceful error handling for user commands #6403

@a-nogikh

Description

@a-nogikh

There are (at least) several very common cases where syzbot could be more user-friendly in reacting to invalid user commands.

Incomplete #syz test commands

The command requires either 0 arguments (in which case syzbot takes the kernel tree/commit where the bug was found) or 2 arguments (tree and the commit). Sometimes users forget that and only supply the tree. Example:

https://lore.kernel.org/all/[email protected]/

Syzbot replies want either no args or 2 args (repo, branch), got 5.

Some options:

  • Provide a better error reply - in the case above there were definitely no 5 arguments.
  • Automatically assume master branch (though some of the trees use main instead).

Incorrectly copy-pasted git patches

Normally, there are no empty lines in a git diff output - such lines will be at least prefixed by a single whitespace. However, these often get lost during copy-pasting.

When syzbot parses the patch out of the email and encounters an empty line, it assumes that it's the end of the patch and cuts it short, which often leads to cryptic error replies (that don't really tell anything useful to the user):
https://lore.kernel.org/all/[email protected]/t/#u

Some options:

  • Provide a better reply in case of "failed to apply patch" errors - tell to specifically watch out for the empty lines.
  • Make the email parsing logic more tolerant to empty lines - AFAIK git apply can still handle these cases normally.

Cc @pimyn-girgis

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions