diff --git a/.golangci.next.reference.yml b/.golangci.next.reference.yml index 2bf475896288..feebb3507103 100644 --- a/.golangci.next.reference.yml +++ b/.golangci.next.reference.yml @@ -2580,6 +2580,8 @@ linters-settings: severity: warning disabled: false exclude: [""] + arguments: + - "xerrors.New" # https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#errorf - name: errorf severity: warning diff --git a/pkg/golinters/revive/testdata/revive.go b/pkg/golinters/revive/testdata/revive.go index 735f1b757bf6..d2e65eabf49a 100644 --- a/pkg/golinters/revive/testdata/revive.go +++ b/pkg/golinters/revive/testdata/revive.go @@ -5,6 +5,8 @@ package testdata import ( "net/http" "time" + + "golang.org/x/xerrors" ) func SampleRevive(t *time.Duration) error { @@ -28,3 +30,7 @@ func testReviveComplexity(s string) { // want "cyclomatic: function testReviveCo return } } + +func testErrorStrings() { + _ = xerrors.New("Some error!") // want "error strings should not be capitalized or end with punctuation or a newline" +} diff --git a/pkg/golinters/revive/testdata/revive.yml b/pkg/golinters/revive/testdata/revive.yml index 5c0c60561db7..414f293c214a 100644 --- a/pkg/golinters/revive/testdata/revive.yml +++ b/pkg/golinters/revive/testdata/revive.yml @@ -17,3 +17,6 @@ linters-settings: arguments: [ 10 ] - name: max-public-structs arguments: [ 3 ] + - name: error-strings + arguments: + - "xerrors.New"