Deprecate maligned, add govet fieldalignment as replacement

[ldez]

Last week, maligned has been deprecated.

The recommendation is to switch to https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/fieldalignment

Related to #1555

Currently, we don't support SuggestedFixes but it's a more global topic.

[Josca]

@ldez please, what is correct way to fix message WARN [runner] The linter 'maligned' is deprecated due to: The repository of the linter has been archived by the owner. Use govet 'fieldalignment' instead.? Just add govet and remove maligned?

[ldez]

yes you just have to disable or remove maligned and add fieldalignment to the govet configuration:

linters:
  disable:
    - maligned

linters-settings:
  govet:
    enable:
      - fieldalignment

linters:
  disable:
    - maligned

linters-settings:
  govet:
    enable-all: true

#1825

[Josca]

@ldez ok, thanks, now it works and it writes a lot of warnings, e.g.:
fieldalignment: struct with 16 pointer bytes could be 8 for:

type RhAccount struct {
	ID   int
	Name string
}

What does it mean, please? I can not find any explanation anywhere.

[Josca]

• oh, sorry, I found that already: https://medium.com/@felipedutratine/how-to-organize-the-go-struct-in-order-to-save-memory-c78afcf59ec2

[iamtakingiteasy]

• oh, sorry, I found that already: https://medium.com/@felipedutratine/how-to-organize-the-go-struct-in-order-to-save-memory-c78afcf59ec2

This is about "struct size" fieldalignment linting, not about "pointer bytes" you've triggered. "Pointer bytes" refers to how much of a struct bytes GC has to scan in order to check the memory, not struct size itself.

See explaination at golang/go#44877 (comment)

#1825 is about making this second type of check non-default as per author intention indicated in comment above. (As it was the case with maligned used in golangci-lint).