chore: duplicate exclusiion structure to avoid side-effect of the serialization

Author: ldez

pkg/config/issues.go

@@ -206,10 +206,10 @@ func validateOptionalRegex(value string) error {
 }
 
 type ExcludePattern struct {
-	ID      string `json:"id,omitempty"`
-	Pattern string `json:"pattern,omitempty"`
-	Linter  string `json:"linter,omitempty"`
-	Why     string `json:"why,omitempty"`
+	ID      string
+	Pattern string
+	Linter  string
+	Why     string
 }
 
 func GetDefaultExcludePatternsStrings() []string {

scripts/website/dump_info/main.go

@@ -15,6 +15,23 @@ import (
 )
 
 func main() {
+	err := saveLinters()
+	if err != nil {
+		log.Fatalf("Save linters: %v", err)
+	}
+
+	err = saveDefaultExclusions()
+	if err != nil {
+		log.Fatalf("Save default exclusions: %v", err)
+	}
+
+	err = saveCLIHelp(filepath.Join("assets", "cli-help.json"))
+	if err != nil {
+		log.Fatalf("Save CLI help: %v", err)
+	}
+}
+
+func saveLinters() error {
 	linters := lintersdb.NewLinterBuilder().Build(config.NewDefault())
 
 	var wraps []types.LinterWrapper
@@ -45,20 +62,22 @@ func main() {
 		wraps = append(wraps, wrapper)
 	}
 
-	err := saveToJSONFile(filepath.Join("assets", "linters-info.json"), wraps)
-	if err != nil {
-		log.Fatalf("Save linters: %v", err)
-	}
+	return saveToJSONFile(filepath.Join("assets", "linters-info.json"), wraps)
+}
 
-	err = saveToJSONFile(filepath.Join("assets", "default-exclusions.json"), config.DefaultExcludePatterns)
-	if err != nil {
-		log.Fatalf("Save default exclusions: %v", err)
-	}
+func saveDefaultExclusions() error {
+	var excludePatterns []types.ExcludePattern
 
-	err = saveCLIHelp(filepath.Join("assets", "cli-help.json"))
-	if err != nil {
-		log.Fatalf("Save CLI help: %v", err)
+	for _, pattern := range config.DefaultExcludePatterns {
+		excludePatterns = append(excludePatterns, types.ExcludePattern{
+			ID:      pattern.ID,
+			Pattern: pattern.Pattern,
+			Linter:  pattern.Linter,
+			Why:     pattern.Why,
+		})
 	}
+
+	return saveToJSONFile(filepath.Join("assets", "default-exclusions.json"), excludePatterns)
 }
 
 func saveCLIHelp(dst string) error {

scripts/website/expand_templates/exclusions.go

@@ -6,11 +6,11 @@ import (
 	"path/filepath"
 	"strings"
 
-	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/scripts/website/types"
 )
 
 func getDefaultExclusions() string {
-	defaultExcludePatterns, err := readJSONFile[[]config.ExcludePattern](filepath.Join("assets", "default-exclusions.json"))
+	defaultExcludePatterns, err := readJSONFile[[]types.ExcludePattern](filepath.Join("assets", "default-exclusions.json"))
 	if err != nil {
 		panic(err)
 	}

scripts/website/types/types.go

@@ -10,6 +10,13 @@ type CLIHelp struct {
 	Help    string `json:"help"`
 }
 
+type ExcludePattern struct {
+	ID      string `json:"id,omitempty"`
+	Pattern string `json:"pattern,omitempty"`
+	Linter  string `json:"linter,omitempty"`
+	Why     string `json:"why,omitempty"`
+}
+
 type Deprecation struct {
 	Since       string `json:"since,omitempty"`
 	Message     string `json:"message,omitempty"`
@@ -30,8 +37,8 @@ type LinterWrapper struct {
 	InPresets        []string `json:"inPresets,omitempty"`
 	AlternativeNames []string `json:"alternativeNames,omitempty"`
 
-	OriginalURL     string `json:"originalURL,omitempty"` // URL of original (not forked) repo, needed for autogenerated README
-	Internal        bool   `json:"internal"`              // Internal linters cannot be disabled (ex: typecheck).
+	OriginalURL     string `json:"originalURL,omitempty"`
+	Internal        bool   `json:"internal"`
 	CanAutoFix      bool   `json:"canAutoFix,omitempty"`
 	IsSlow          bool   `json:"isSlow"`
 	DoesChangeTypes bool   `json:"doesChangeTypes,omitempty"`