Add noinlineerr linter (#5826)

Author: AlwxSin

.golangci.next.reference.yml

@@ -91,6 +91,7 @@ linters:
     - nilnil
     - nlreturn
     - noctx
+    - noinlineerr
     - nolintlint
     - nonamedreturns
     - nosprintfhostport
@@ -200,6 +201,7 @@ linters:
     - nilnil
     - nlreturn
     - noctx
+    - noinlineerr
     - nolintlint
     - nonamedreturns
     - nosprintfhostport

go.mod

@@ -7,6 +7,7 @@ require (
 	4d63.com/gochecknoglobals v0.2.2
 	github.com/4meepo/tagalign v1.4.2
 	github.com/Abirdcfly/dupword v0.1.6
+	github.com/AlwxSin/noinlineerr v1.0.3
 	github.com/Antonboom/errname v1.1.0
 	github.com/Antonboom/nilnil v1.1.0
 	github.com/Antonboom/testifylint v1.6.1

go.sum

@@ -794,6 +794,7 @@
             "nilnil",
             "nlreturn",
             "noctx",
+            "noinlineerr",
             "nolintlint",
             "nonamedreturns",
             "nosprintfhostport",

jsonschema/golangci.next.jsonschema.json

@@ -0,0 +1,13 @@
+package noinlineerr
+
+import (
+	"github.com/AlwxSin/noinlineerr"
+
+	"github.com/golangci/golangci-lint/v2/pkg/goanalysis"
+)
+
+func New() *goanalysis.Linter {
+	return goanalysis.
+		NewLinterFromAnalyzer(noinlineerr.NewAnalyzer()).
+		WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/noinlineerr/noinlineerr.go

@@ -0,0 +1,19 @@
+package noinlineerr
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/v2/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}
+
+func TestFix(t *testing.T) {
+	integration.RunFix(t)
+}
+
+func TestFixPathPrefix(t *testing.T) {
+	integration.RunFixPathPrefix(t)
+}

pkg/golinters/noinlineerr/noinlineerr_integration_test.go

@@ -0,0 +1,59 @@
+//golangcitest:args -Enoinlineerr
+//golangcitest:expected_exitcode 0
+package testdata
+
+type MyAliasErr error
+
+type MyCustomError struct{}
+
+func (mc *MyCustomError) Error() string {
+	return "error"
+}
+
+func doSomething() error {
+	return nil
+}
+
+func doSmthManyArgs(a, b, c, d int) error {
+	return nil
+}
+
+func doSmthMultipleReturn() (bool, error) {
+	return false, nil
+}
+
+func doMyAliasErr() MyAliasErr {
+	return nil
+}
+
+func doMyCustomErr() *MyCustomError {
+	return &MyCustomError{}
+}
+
+func invalid() error {
+	err := doSomething()
+	if err != nil {
+		return err
+	}
+
+	err = doSmthManyArgs(0,
+		0,
+		0,
+		0,
+	)
+	if err != nil {
+		return err
+	}
+
+	err = doMyAliasErr()
+	if err != nil {
+		return err
+	}
+
+	err = doMyCustomErr()
+	if err != nil {
+		return err
+	}
+
+	return nil
+}

pkg/golinters/noinlineerr/testdata/fix/in/noinlineerr.go

@@ -0,0 +1,59 @@
+//golangcitest:args -Enoinlineerr
+//golangcitest:expected_exitcode 0
+package testdata
+
+type MyAliasErr error
+
+type MyCustomError struct{}
+
+func (mc *MyCustomError) Error() string {
+	return "error"
+}
+
+func doSomething() error {
+	return nil
+}
+
+func doSmthManyArgs(a, b, c, d int) error {
+	return nil
+}
+
+func doSmthMultipleReturn() (bool, error) {
+	return false, nil
+}
+
+func doMyAliasErr() MyAliasErr {
+	return nil
+}
+
+func doMyCustomErr() *MyCustomError {
+	return &MyCustomError{}
+}
+
+func invalid() error {
+	err := doSomething()
+	if err != nil {
+		return err
+	}
+
+	err = doSmthManyArgs(0,
+		0,
+		0,
+		0,
+	)
+	if err != nil {
+		return err
+	}
+
+	err = doMyAliasErr()
+	if err != nil {
+		return err
+	}
+
+	err = doMyCustomErr()
+	if err != nil {
+		return err
+	}
+
+	return nil
+}

pkg/golinters/noinlineerr/testdata/fix/out/noinlineerr.go

@@ -0,0 +1,87 @@
+//golangcitest:args -Enoinlineerr
+package testdata
+
+import (
+	"fmt"
+	"strconv"
+)
+
+type MyAliasErr error
+
+type MyCustomError struct {}
+
+func (mc *MyCustomError) Error() string {
+	return "error"
+}
+
+func doSomething() error {
+	return nil
+}
+
+func doSmthManyArgs(a, b, c, d int) error {
+	return nil
+}
+
+func doSmthMultipleReturn() (bool, error) {
+	return false, nil
+}
+
+func doMyAliasErr() MyAliasErr {
+	return nil
+}
+
+func doMyCustomErr() *MyCustomError {
+	return &MyCustomError{}
+}
+
+func valid() error {
+	err := doSomething() // ok
+	if err != nil {
+		return err
+	}
+
+	err = doSmthManyArgs(0, 0, 0, 0) // ok
+	if err != nil {
+		return err
+	}
+
+	_, err = doSmthMultipleReturn() // ok
+	if err != nil {
+		return err
+	}
+
+	if ok, _ := strconv.ParseBool("1"); ok {
+		fmt.Println("ok")
+	}
+
+	return nil
+}
+
+func invalid() error {
+	if err := doSomething(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...`"
+		return err
+	}
+
+	if err := doSmthManyArgs(0, // want "avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...`"
+		0,
+		0,
+		0,
+	); err != nil {
+		return err
+	}
+
+	if _, err := doSmthMultipleReturn(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...`"
+		_ = false
+		return err
+	}
+
+	if err := doMyAliasErr(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...`"
+		return err
+	}
+
+	if err := doMyCustomErr(); err != nil { // want "avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...`"
+		return err
+	}
+
+	return nil
+}

pkg/golinters/noinlineerr/testdata/noinlineerr.go

@@ -79,6 +79,7 @@ import (
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/nilnil"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/nlreturn"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/noctx"
+	"github.com/golangci/golangci-lint/v2/pkg/golinters/noinlineerr"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/nolintlint"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/nonamedreturns"
 	"github.com/golangci/golangci-lint/v2/pkg/golinters/nosprintfhostport"
@@ -511,6 +512,11 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/sonatard/noctx"),
 
+		linter.NewConfig(noinlineerr.New()).
+			WithSince("v2.2.0").
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/AlwxSin/noinlineerr"),
+
 		linter.NewConfig(nonamedreturns.New(&cfg.Linters.Settings.NoNamedReturns)).
 			WithSince("v1.46.0").
 			WithLoadForGoAnalysis().