varnamelen: fix configuration (#5904)

Author: ldez

pkg/golinters/varnamelen/testdata/varnamelen_configuration.go

@@ -0,0 +1,30 @@
+//golangcitest:args -Evarnamelen
+//golangcitest:config_path testdata/varnamelen_configuration.yml
+//golangcitest:expected_exitcode 0
+package testdata
+
+import "fmt"
+
+func _() {
+	ok := foo()
+
+	fmt.Println("a")
+	fmt.Println("b")
+	fmt.Println("c")
+	fmt.Println("d")
+	println(ok)
+}
+
+func _() {
+	fn := foo()
+
+	fmt.Println("a")
+	fmt.Println("b")
+	fmt.Println("c")
+	fmt.Println("d")
+	println(fn)
+}
+
+func foo() bool {
+	return true
+}

pkg/golinters/varnamelen/testdata/varnamelen_configuration.yml

@@ -0,0 +1,9 @@
+version: "2"
+
+linters:
+  settings:
+    varnamelen:
+      ignore-names:
+        - fn
+      ignore-decls:
+        - ok bool

pkg/golinters/varnamelen/varnamelen.go

@@ -14,7 +14,7 @@ func New(settings *config.VarnamelenSettings) *goanalysis.Linter {
 	var cfg map[string]any
 
 	if settings != nil {
-		vnlCfg := map[string]any{
+		cfg = map[string]any{
 			"checkReceiver":      strconv.FormatBool(settings.CheckReceiver),
 			"checkReturn":        strconv.FormatBool(settings.CheckReturn),
 			"checkTypeParam":     strconv.FormatBool(settings.CheckTypeParam),
@@ -26,11 +26,11 @@ func New(settings *config.VarnamelenSettings) *goanalysis.Linter {
 		}
 
 		if settings.MaxDistance > 0 {
-			vnlCfg["maxDistance"] = strconv.Itoa(settings.MaxDistance)
+			cfg["maxDistance"] = strconv.Itoa(settings.MaxDistance)
 		}
 
 		if settings.MinNameLength > 0 {
-			vnlCfg["minNameLength"] = strconv.Itoa(settings.MinNameLength)
+			cfg["minNameLength"] = strconv.Itoa(settings.MinNameLength)
 		}
 	}