review

Author: ldez

pkg/commands/internal/migrate/migrate_formatters.go

@@ -10,12 +10,10 @@ import (
 )
 
 func toFormatters(old *versionone.Config) versiontwo.Formatters {
-	enable, _ := ProcessEffectiveLinters(old.Linters)
-
-	formatterNames := onlyFormatterNames(enable)
+	enable := ProcessEffectiveFormatters(old.Linters)
 
 	var paths []string
-	if len(formatterNames) > 0 {
+	if len(enable) > 0 {
 		paths = slices.Concat(old.Issues.ExcludeFiles, old.Issues.ExcludeDirs)
 
 		if old.Issues.UseDefaultExcludeDirs == nil || ptr.Deref(old.Issues.UseDefaultExcludeDirs) {
@@ -26,7 +24,7 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
 	paths = append(paths, toFormattersPathsFromRules(old.Issues)...)
 
 	return versiontwo.Formatters{
-		Enable: formatterNames,
+		Enable: enable,
 		Settings: versiontwo.FormatterSettings{
 			Gci:       toGciSettings(old.LintersSettings.Gci),
 			GoFmt:     toGoFmtSettings(old.LintersSettings.GoFmt),

pkg/commands/internal/migrate/migrate_linter_names.go

@@ -38,13 +38,33 @@ func ProcessEffectiveLinters(old versionone.Linters) (enable, disable []string)
 	switch {
 	case ptr.Deref(old.DisableAll):
 		return disableAllFilter(old), nil
+
 	case ptr.Deref(old.EnableAll):
 		return nil, enableAllFilter(old)
+
 	default:
 		return defaultLintersFilter(old)
 	}
 }
 
+func ProcessEffectiveFormatters(old versionone.Linters) []string {
+	enabled, disabled := ProcessEffectiveLinters(old)
+
+	if ptr.Deref(old.EnableAll) {
+		var formatterNames []string
+
+		for _, f := range getAllFormatterNames() {
+			if !slices.Contains(disabled, f) {
+				formatterNames = append(formatterNames, f)
+			}
+		}
+
+		return formatterNames
+	}
+
+	return onlyFormatterNames(enabled)
+}
+
 // disableAllFilter generates the value of `enable` when `disable-all` is `true`.
 func disableAllFilter(old versionone.Linters) []string {
 	// Note:
@@ -827,6 +847,7 @@ func unknownLinterNames(names []string, linters []LinterInfo) []string {
 		"scopelint",
 		"structcheck",
 		"tenv",
+		"typecheck",
 		"varcheck",
 	}
 
@@ -879,7 +900,7 @@ func onlyLinterNames(names []string) []string {
 }
 
 func onlyFormatterNames(names []string) []string {
-	formatters := []string{"gci", "gofmt", "gofumpt", "goimports"}
+	formatters := getAllFormatterNames()
 
 	var results []string
 
@@ -920,3 +941,7 @@ func convertAlternativeNames(names []string) []string {
 func Unique[S ~[]E, E cmp.Ordered](s S) S {
 	return slices.Compact(slices.Sorted(slices.Values(s)))
 }
+
+func getAllFormatterNames() []string {
+	return []string{"gci", "gofmt", "gofumpt", "goimports"}
+}

pkg/commands/internal/migrate/testdata/linters_05.golden.yml

@@ -19,3 +19,9 @@ linters:
     - durationcheck
     - err113
     - errcheck
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+    - goimports

pkg/commands/internal/migrate/testdata/linters_08.golden.yml

@@ -75,3 +75,8 @@ linters:
     - wastedassign
     - wrapcheck
     - zerologlint
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports

pkg/commands/internal/migrate/testdata/linters_11.golden.yml

@@ -0,0 +1,8 @@
+version: "2"
+linters:
+  default: all
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports

pkg/commands/internal/migrate/testdata/linters_11.yml

@@ -0,0 +1,11 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  enable-all: true
+  disable:
+    - typecheck
+    - gci

pkg/commands/internal/migrate/testdata/linters_12.golden.yml

@@ -0,0 +1,5 @@
+version: "2"
+linters:
+  default: none
+  enable:
+    - govet

pkg/commands/internal/migrate/testdata/linters_12.yml

@@ -0,0 +1,11 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  disable-all: true
+  enable:
+    - typecheck
+    - govet