dev: remove IdentifierMarker (#5523)

Author: ldez

pkg/golinters/unparam/testdata/unparam.go

@@ -1,7 +1,7 @@
 //golangcitest:args -Eunparam
 package testdata
 
-func unparamUnused(a, b uint) uint { // want "`unparamUnused` - `b` is unused"
+func unparamUnused(a, b uint) uint { // want "unparamUnused - b is unused"
 	a++
 	return a
 }

pkg/golinters/unparam/testdata/unparam_cgo.go

@@ -25,7 +25,7 @@ func _() {
 	C.free(unsafe.Pointer(cs))
 }
 
-func unparamUnusedCGO(a, b uint) uint { // want "`unparamUnusedCGO` - `b` is unused"
+func unparamUnusedCGO(a, b uint) uint { // want "unparamUnusedCGO - b is unused"
 	a++
 	return a
 }

pkg/golinters/unused/testdata/unused.go

@@ -1,19 +1,19 @@
 //golangcitest:args -Eunused
 package testdata
 
-func fn1() {} // want "func `fn1` is unused"
+func fn1() {} // want "func fn1 is unused"
 
 //nolint:unused
 func fn2() { fn3() }
 
-func fn3() {} // want "func `fn3` is unused"
+func fn3() {} // want "func fn3 is unused"
 
-func fn4() { fn5() } // want "func `fn4` is unused"
+func fn4() { fn5() } // want "func fn4 is unused"
 
-func fn5() {} // want "func `fn5` is unused"
+func fn5() {} // want "func fn5 is unused"
 
-func fn6() { fn4() } // want "func `fn6` is unused"
+func fn6() { fn4() } // want "func fn6 is unused"
 
-type unusedStruct struct{} // want "type `unusedStruct` is unused"
+type unusedStruct struct{} // want "type unusedStruct is unused"
 
 type unusedStructNolintUnused struct{} //nolint:unused

pkg/golinters/unused/testdata/unused_cgo.go

@@ -25,4 +25,4 @@ func _() {
 	C.free(unsafe.Pointer(cs))
 }
 
-func fn1() {} // want "func `fn1` is unused"
+func fn1() {} // want "func fn1 is unused"

pkg/lint/runner.go

@@ -90,9 +90,6 @@ func NewRunner(log logutils.Log, cfg *config.Config, goenv *goutil.Env,
 
 			processors.NewGeneratedFileFilter(cfg.Linters.Exclusions.Generated),
 
-			// Must be before exclude because users see already marked output and configure excluding by it.
-			processors.NewIdentifierMarker(),
-
 			processors.NewExclusionRules(log.Child(logutils.DebugKeyExclusionRules), lineCache,
 				&cfg.Linters.Exclusions),
 

pkg/result/processors/identifier_marker.go

@@ -365,7 +365,7 @@ func TestSortedResults(t *testing.T) {
 		Run().
 		ExpectExitCode(exitcodes.IssuesFound).ExpectOutputEq(
 		"testdata/sort_results/main.go:15:13: Error return value is not checked (errcheck)" + "\n" +
-			"testdata/sort_results/main.go:12:5: var `db` is unused (unused)" + "\n",
+			"testdata/sort_results/main.go:12:5: var db is unused (unused)" + "\n",
 	)
 }