tests: add test files

Author: ldez

pkg/golinters/modernize/testdata/fix/in/any.go

@@ -0,0 +1,12 @@
+//golangcitest:args -Emodernize
+//golangcitest:expected_exitcode 0
+package any
+
+func _(x interface{}) {} // want "interface{} can be replaced by any"
+
+func _() {
+	var x interface{} // want "interface{} can be replaced by any"
+	const any = 1
+	var y interface{} // nope: any is shadowed here
+	_, _ = x, y
+}

pkg/golinters/modernize/testdata/fix/in/bloop_test.go

@@ -0,0 +1,115 @@
+//golangcitest:args -Emodernize
+//golangcitest:expected_exitcode 0
+package bloop
+
+import (
+	"sync"
+	"testing"
+)
+
+func BenchmarkA(b *testing.B) {
+	println("slow")
+	b.ResetTimer()
+
+	for range b.N { // want "b.N can be modernized using b.Loop.."
+	}
+}
+
+func BenchmarkB(b *testing.B) {
+	// setup
+	{
+		b.StopTimer()
+		println("slow")
+		b.StartTimer()
+	}
+
+	for i := range b.N { // Nope. Should we change this to "for i := 0; b.Loop(); i++"?
+		print(i)
+	}
+
+	b.StopTimer()
+	println("slow")
+}
+
+func BenchmarkC(b *testing.B) {
+	// setup
+	{
+		b.StopTimer()
+		println("slow")
+		b.StartTimer()
+	}
+
+	for i := 0; i < b.N; i++ { // want "b.N can be modernized using b.Loop.."
+		println("no uses of i")
+	}
+
+	b.StopTimer()
+	println("slow")
+}
+
+func BenchmarkD(b *testing.B) {
+	for i := 0; i < b.N; i++ { // want "b.N can be modernized using b.Loop.."
+		println(i)
+	}
+}
+
+func BenchmarkE(b *testing.B) {
+	b.Run("sub", func(b *testing.B) {
+		b.StopTimer() // not deleted
+		println("slow")
+		b.StartTimer() // not deleted
+
+		// ...
+	})
+	b.ResetTimer()
+
+	for i := 0; i < b.N; i++ { // want "b.N can be modernized using b.Loop.."
+		println("no uses of i")
+	}
+
+	b.StopTimer()
+	println("slow")
+}
+
+func BenchmarkF(b *testing.B) {
+	var wg sync.WaitGroup
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		for i := 0; i < b.N; i++ { // nope: b.N accessed from a FuncLit
+		}
+	}()
+	wg.Wait()
+}
+
+func BenchmarkG(b *testing.B) {
+	var wg sync.WaitGroup
+	poster := func() {
+		for i := 0; i < b.N; i++ { // nope: b.N accessed from a FuncLit
+		}
+		wg.Done()
+	}
+	wg.Add(2)
+	for i := 0; i < 2; i++ {
+		go poster()
+	}
+	wg.Wait()
+}
+
+func BenchmarkH(b *testing.B) {
+	var wg sync.WaitGroup
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		for range b.N { // nope: b.N accessed from a FuncLit
+		}
+	}()
+	wg.Wait()
+}
+
+func BenchmarkI(b *testing.B) {
+	for i := 0; i < b.N; i++ { // nope: b.N accessed more than once in benchmark
+	}
+	for i := 0; i < b.N; i++ { // nope: b.N accessed more than once in benchmark
+	}
+}

pkg/golinters/modernize/testdata/fix/in/fieldsseq.go

@@ -0,0 +1,42 @@
+//golangcitest:args -Emodernize
+//golangcitest:expected_exitcode 0
+package fieldsseq
+
+import (
+	"bytes"
+	"strings"
+)
+
+func _() {
+	for _, line := range strings.Fields("") { // want "Ranging over FieldsSeq is more efficient"
+		println(line)
+	}
+	for i, line := range strings.Fields("") { // nope: uses index var
+		println(i, line)
+	}
+	for i, _ := range strings.Fields("") { // nope: uses index var
+		println(i)
+	}
+	for i := range strings.Fields("") { // nope: uses index var
+		println(i)
+	}
+	for _ = range strings.Fields("") { // want "Ranging over FieldsSeq is more efficient"
+	}
+	for range strings.Fields("") { // want "Ranging over FieldsSeq is more efficient"
+	}
+	for range bytes.Fields(nil) { // want "Ranging over FieldsSeq is more efficient"
+	}
+	{
+		lines := strings.Fields("") // want "Ranging over FieldsSeq is more efficient"
+		for _, line := range lines {
+			println(line)
+		}
+	}
+	{
+		lines := strings.Fields("") // nope: lines is used not just by range
+		for _, line := range lines {
+			println(line)
+		}
+		println(lines)
+	}
+}

pkg/golinters/modernize/testdata/fix/in/fmtappendf.go

@@ -0,0 +1,46 @@
+//golangcitest:args -Emodernize
+//golangcitest:expected_exitcode 0
+package fmtappendf
+
+import (
+	"fmt"
+)
+
+func two() string {
+	return "two"
+}
+
+func bye() {
+	_ = []byte(fmt.Sprintf("bye %d", 1)) // want "Replace .*Sprintf.* with fmt.Appendf"
+}
+
+func funcsandvars() {
+	one := "one"
+	_ = []byte(fmt.Sprintf("bye %d %s %s", 1, two(), one)) // want "Replace .*Sprintf.* with fmt.Appendf"
+}
+
+func typealias() {
+	type b = byte
+	type bt = []byte
+	_ = []b(fmt.Sprintf("bye %d", 1)) // want "Replace .*Sprintf.* with fmt.Appendf"
+	_ = bt(fmt.Sprintf("bye %d", 1))  // want "Replace .*Sprintf.* with fmt.Appendf"
+}
+
+func otherprints() {
+	_ = []byte(fmt.Sprint("bye %d", 1))   // want "Replace .*Sprint.* with fmt.Append"
+	_ = []byte(fmt.Sprintln("bye %d", 1)) // want "Replace .*Sprintln.* with fmt.Appendln"
+}
+
+func comma() {
+	type S struct{ Bytes []byte }
+	var _ = struct{ A S }{
+		A: S{
+			Bytes: []byte( // want "Replace .*Sprint.* with fmt.Appendf"
+				fmt.Sprintf("%d", 0),
+			),
+		},
+	}
+	_ = []byte( // want "Replace .*Sprint.* with fmt.Appendf"
+		fmt.Sprintf("%d", 0),
+	)
+}

pkg/golinters/modernize/testdata/fix/in/forvar.go

@@ -0,0 +1,91 @@
+//golangcitest:args -Emodernize
+//golangcitest:expected_exitcode 0
+package forvar
+
+func _(m map[int]int, s []int) {
+	// changed
+	for i := range s {
+		i := i // want "copying variable is unneeded"
+		go f(i)
+	}
+	for _, v := range s {
+		v := v // want "copying variable is unneeded"
+		go f(v)
+	}
+	for k, v := range m {
+		k := k // want "copying variable is unneeded"
+		v := v // want "copying variable is unneeded"
+		go f(k)
+		go f(v)
+	}
+	for k, v := range m {
+		v := v // want "copying variable is unneeded"
+		k := k // want "copying variable is unneeded"
+		go f(k)
+		go f(v)
+	}
+	for k, v := range m {
+		k, v := k, v // want "copying variable is unneeded"
+		go f(k)
+		go f(v)
+	}
+	for k, v := range m {
+		v, k := v, k // want "copying variable is unneeded"
+		go f(k)
+		go f(v)
+	}
+	for i := range s {
+		/* hi */ i := i // want "copying variable is unneeded"
+		go f(i)
+	}
+	// nope
+	var i, k, v int
+
+	for i = range s { // nope, scope change
+		i := i
+		go f(i)
+	}
+	for _, v = range s { // nope, scope change
+		v := v
+		go f(v)
+	}
+	for k = range m { // nope, scope change
+		k := k
+		go f(k)
+	}
+	for k, v = range m { // nope, scope change
+		k := k
+		v := v
+		go f(k)
+		go f(v)
+	}
+	for _, v = range m { // nope, scope change
+		v := v
+		go f(v)
+	}
+	for _, v = range m { // nope, not x := x
+		v := i
+		go f(v)
+	}
+	for k, v := range m { // nope, LHS and RHS differ
+		v, k := k, v
+		go f(k)
+		go f(v)
+	}
+	for k, v := range m { // nope, not a simple redecl
+		k, v, x := k, v, 1
+		go f(k)
+		go f(v)
+		go f(x)
+	}
+	for i := range s { // nope, not a simple redecl
+		i := (i)
+		go f(i)
+	}
+	for i := range s { // nope, not a simple redecl
+		i := i + 1
+		go f(i)
+	}
+}
+
+func f(n int) {}