feat: add intrange linter (#4378)

Author: ckaznocha

.golangci.reference.yml

@@ -2538,6 +2538,7 @@ linters:
     - ineffassign
     - interfacebloat
     - interfacer
+    - intrange
     - ireturn
     - lll
     - loggercheck
@@ -2659,6 +2660,7 @@ linters:
     - ineffassign
     - interfacebloat
     - interfacer
+    - intrange
     - ireturn
     - lll
     - loggercheck

go.mod

@@ -29,6 +29,7 @@ require (
 	github.com/butuzov/mirror v1.1.0
 	github.com/catenacyber/perfsprint v0.7.0
 	github.com/charithe/durationcheck v0.0.10
+	github.com/ckaznocha/intrange v0.1.0
 	github.com/curioswitch/go-reassign v0.2.0
 	github.com/daixiang0/gci v0.12.1
 	github.com/denis-tingaikin/go-header v0.4.3

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/ckaznocha/intrange"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewIntrange() *goanalysis.Linter {
+	a := intrange.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/intrange.go

@@ -608,6 +608,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/mvdan/interfacer").
 			Deprecated("The repository of the linter has been archived by the owner.", "v1.38.0", ""),
 
+		linter.NewConfig(golinters.NewIntrange()).
+			WithSince("v1.57.0").
+			WithURL("https://github.com/ckaznocha/intrange"),
+
 		linter.NewConfig(golinters.NewIreturn(ireturnCfg)).
 			WithSince("v1.43.0").
 			WithPresets(linter.PresetStyle).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,19 @@
+//golangcitest:args -Eintrange
+package testdata
+
+import "math"
+
+func CheckIntrange() {
+	for i := 0; i < 10; i++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
+	}
+
+	for i := uint8(0); i < math.MaxInt8; i++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)`
+	}
+
+	for i := 0; i < 10; i += 2 {
+	}
+
+	for i := 0; i < 10; i++ {
+		i += 1
+	}
+}