review

Author: ldez

pkg/config/base_rule.go

@@ -59,7 +59,7 @@ func (b *BaseRule) Validate(minConditionsCount int) error {
 	}
 
 	if nonBlank < minConditionsCount {
-		return fmt.Errorf("at least %d of (text, source, path[-except],  linters) should be set", minConditionsCount)
+		return fmt.Errorf("at least %d of (text, source, path[-except], linters) should be set", minConditionsCount)
 	}
 
 	return nil

pkg/config/issues_test.go

@@ -34,7 +34,7 @@ func TestExcludeRule_Validate(t *testing.T) {
 		{
 			desc:     "empty rule",
 			rule:     &ExcludeRule{},
-			expected: "at least 2 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 2 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "only path rule",
@@ -43,7 +43,7 @@ func TestExcludeRule_Validate(t *testing.T) {
 					Path: "test",
 				},
 			},
-			expected: "at least 2 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 2 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "only path-except rule",
@@ -52,7 +52,7 @@ func TestExcludeRule_Validate(t *testing.T) {
 					PathExcept: "test",
 				},
 			},
-			expected: "at least 2 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 2 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "only text rule",
@@ -61,7 +61,7 @@ func TestExcludeRule_Validate(t *testing.T) {
 					Text: "test",
 				},
 			},
-			expected: "at least 2 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 2 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "only source rule",
@@ -70,7 +70,7 @@ func TestExcludeRule_Validate(t *testing.T) {
 					Source: "test",
 				},
 			},
-			expected: "at least 2 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 2 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "invalid path rule",

pkg/config/severity_test.go

@@ -136,7 +136,7 @@ func TestSeverityRule_Validate_error(t *testing.T) {
 			rule: &SeverityRule{
 				Severity: "low",
 			},
-			expected: "at least 1 of (text, source, path[-except],  linters) should be set",
+			expected: "at least 1 of (text, source, path[-except], linters) should be set",
 		},
 		{
 			desc: "invalid path rule",

pkg/result/processors/exclusion_paths.go

@@ -95,7 +95,7 @@ func (p *ExclusionPaths) Finish() {
 func (p *ExclusionPaths) shouldPassIssue(issue *result.Issue) bool {
 	for _, pattern := range p.pathPatterns {
 		if pattern.MatchString(issue.RelativePath) {
-			p.excludedPathCounter[pattern] += 1
+			p.excludedPathCounter[pattern]++
 			return false
 		}
 	}
@@ -110,7 +110,7 @@ func (p *ExclusionPaths) shouldPassIssue(issue *result.Issue) bool {
 			continue
 		}
 
-		p.excludedPathExceptCounter[pattern] += 1
+		p.excludedPathExceptCounter[pattern]++
 		matched = true
 	}