WIP

Author: ldez

.gitignore

@@ -18,3 +18,7 @@
 /vendor/
 coverage.out
 coverage.xml
+
+/custom-golangci-lint
+/gcl-custom
+.mygcl.yml

.golangci.yml

@@ -80,6 +80,7 @@ linters-settings:
         disabled: true
       - name: unused-parameter
 
+
 linters:
   disable-all: true
   enable:

cmd/golangci-lint/plugins.go

@@ -0,0 +1,3 @@
+package main
+
+import _ "github.com/golangci/golangci-lint/pkg/experimental/modules/myplugin"

pkg/commands/root.go

@@ -11,6 +11,7 @@ import (
 	"github.com/spf13/pflag"
 
 	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/experimental/commands/custom"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/report"
 )
@@ -66,6 +67,7 @@ func newRootCommand(info BuildInfo) *rootCommand {
 		newCacheCommand().cmd,
 		newConfigCommand(log).cmd,
 		newVersionCommand(info).cmd,
+		custom.NewCommand(log).Cmd,
 	)
 
 	rootCmd.SetHelpCommand(newHelpCommand(log).cmd)

pkg/commands/run.go

@@ -31,6 +31,7 @@ import (
 	"github.com/golangci/golangci-lint/internal/pkgcache"
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/exitcodes"
+	"github.com/golangci/golangci-lint/pkg/experimental/db"
 	"github.com/golangci/golangci-lint/pkg/fsutils"
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis/load"
 	"github.com/golangci/golangci-lint/pkg/goutil"
@@ -177,7 +178,7 @@ func (c *runCommand) persistentPostRunE(_ *cobra.Command, _ []string) error {
 
 func (c *runCommand) preRunE(_ *cobra.Command, _ []string) error {
 	dbManager, err := lintersdb.NewManager(c.log.Child(logutils.DebugKeyLintersDB), c.cfg,
-		lintersdb.NewPluginBuilder(c.log), lintersdb.NewLinterBuilder())
+		db.NewPluginBuilderWrapper(c.log), lintersdb.NewLinterBuilder())
 	if err != nil {
 		return err
 	}

pkg/config/linters_settings.go

@@ -3,6 +3,7 @@ package config
 import (
 	"encoding"
 	"errors"
+	"fmt"
 	"runtime"
 
 	"gopkg.in/yaml.v3"
@@ -280,7 +281,17 @@ type LintersSettings struct {
 }
 
 func (s *LintersSettings) Validate() error {
-	return s.Govet.Validate()
+	if err := s.Govet.Validate(); err != nil {
+		return err
+	}
+
+	for name, settings := range s.Custom {
+		if err := settings.Validate(); err != nil {
+			return fmt.Errorf("custom linter %q: %w", name, err)
+		}
+	}
+
+	return nil
 }
 
 type AsasalintSettings struct {
@@ -958,4 +969,19 @@ type CustomLinterSettings struct {
 
 	// Settings plugin settings only work with linterdb.PluginConstructor symbol.
 	Settings any
+
+	// FIXME goplugin,module
+	Type string `mapstructure:"type"`
+}
+
+func (s *CustomLinterSettings) Validate() error {
+	if s.Type == "module" {
+		return nil
+	}
+
+	if s.Path == "" {
+		return errors.New("path is required")
+	}
+
+	return nil
 }

pkg/experimental/commands/.mygcl.reference.yml

@@ -0,0 +1,24 @@
+version: v1.56.2
+name: custom-golangci-lint # optional, default: gcl-custom
+plugins:
+  # a plugin from a Go proxy
+  - module: 'github.com/example/plugin3'
+    version: v1.2.3
+
+  # a plugin from a Go proxy (with a specific import path)
+  - module: 'github.com/example/plugin4'
+    import: 'github.com/example/plugin4/foo'
+    version: v1.0.0
+
+  # a plugin from local source (with absolute path)
+  - module: 'github.com/example/plugin2'
+    path: /my/local/path/plugin2
+
+  # a plugin from local source (with relative path)
+  - module: 'github.com/example/plugin1'
+    path: ./my/local/path/plugin1
+
+  # a plugin from local source (with absolute path and a specific import path)
+  - module: 'github.com/example/plugin2'
+    import: 'github.com/example/plugin4/foo'
+    path: /my/local/path/plugin2

pkg/experimental/commands/custom/custom.go

@@ -0,0 +1,81 @@
+package custom
+
+import (
+	"context"
+	"fmt"
+	"log"
+	"os"
+
+	"github.com/spf13/cobra"
+
+	"github.com/golangci/golangci-lint/pkg/experimental/commands/custom/internal"
+	"github.com/golangci/golangci-lint/pkg/logutils"
+)
+
+const envKeepTempFiles = "MYGCL_KEEP_TEMP_FILES"
+
+type Command struct {
+	Cmd *cobra.Command
+
+	cfg *internal.Configuration
+
+	log logutils.Log
+}
+
+func NewCommand(logger logutils.Log) *Command {
+	c := &Command{log: logger}
+
+	customCmd := &cobra.Command{
+		Use:     "custom",
+		Short:   "Build a version of golangci-lint with custom linters.",
+		Args:    cobra.NoArgs,
+		PreRunE: c.preRunE,
+		RunE:    c.runE,
+	}
+
+	c.Cmd = customCmd
+
+	return c
+}
+
+func (c *Command) preRunE(_ *cobra.Command, _ []string) error {
+	cfg, err := internal.LoadConfiguration()
+	if err != nil {
+		return err
+	}
+
+	err = cfg.Validate()
+	if err != nil {
+		return err
+	}
+
+	c.cfg = cfg
+
+	return nil
+}
+
+func (c *Command) runE(_ *cobra.Command, _ []string) error {
+	ctx := context.Background()
+
+	tmp, err := os.MkdirTemp(os.TempDir(), "mygcl")
+	if err != nil {
+		return fmt.Errorf("create temporary directory: %w", err)
+	}
+
+	defer func() {
+		if os.Getenv(envKeepTempFiles) != "" {
+			log.Printf("WARN: The env var %s has been dectected: the temporary directory is preserved: %s", envKeepTempFiles, tmp)
+
+			return
+		}
+
+		_ = os.RemoveAll(tmp)
+	}()
+
+	err = internal.NewBuilder(c.log, c.cfg, tmp).Build(ctx)
+	if err != nil {
+		return fmt.Errorf("build process: %w", err)
+	}
+
+	return nil
+}