chore: use new language elements

Author: ldez

pkg/commands/internal/migrate/versionone/output.go

@@ -24,9 +24,7 @@ type OutputFormat struct {
 type OutputFormats []OutputFormat
 
 func (p *OutputFormats) UnmarshalText(text []byte) error {
-	formats := strings.Split(string(text), ",")
-
-	for _, item := range formats {
+	for item := range strings.SplitSeq(string(text), ",") {
 		format, path, _ := strings.Cut(item, ":")
 
 		*p = append(*p, OutputFormat{

pkg/goutil/version.go

@@ -60,9 +60,7 @@ func CleanRuntimeVersion() (string, error) {
 }
 
 func cleanRuntimeVersion(rv string) (string, error) {
-	parts := strings.Fields(rv)
-
-	for _, part := range parts {
+	for part := range strings.FieldsSeq(rv) {
 		// Allow to handle:
 		// - GOEXPERIMENT -> "go1.23.0 X:boringcrypto"
 		// - devel -> "devel go1.24-e705a2d Wed Aug 7 01:16:42 2024 +0000 linux/amd64"

pkg/logutils/logutils.go

@@ -94,7 +94,7 @@ func getEnabledDebugs() map[string]bool {
 		return ret
 	}
 
-	for _, tag := range strings.Split(debugVar, ",") {
+	for tag := range strings.SplitSeq(debugVar, ",") {
 		ret[tag] = true
 	}
 

pkg/result/processors/nolint_filter.go

@@ -227,11 +227,12 @@ func (p *NolintFilter) extractInlineRangeFromComment(text string, g ast.Node, fs
 		return buildRange(nil) // ignore all linters
 	}
 
+	text, _, _ = strings.Cut(text, "//") // allow another comment after this comment
+
 	// ignore specific linters
 	var linters []string
-	text = strings.Split(text, "//")[0] // allow another comment after this comment
-	linterItems := strings.Split(strings.TrimPrefix(text, "nolint:"), ",")
-	for _, item := range linterItems {
+
+	for item := range strings.SplitSeq(strings.TrimPrefix(text, "nolint:"), ",") {
 		linterName := strings.ToLower(strings.TrimSpace(item))
 		if linterName == "all" {
 			p.unknownLintersSet = map[string]bool{}

scripts/gen_github_action_config/main.go

@@ -219,10 +219,9 @@ func parseVersion(s string) (*version, error) {
 		return nil, fmt.Errorf("version %q should start with %q", s, vPrefix)
 	}
 
-	parts := strings.Split(strings.TrimPrefix(s, vPrefix), ".")
-
 	var nums []int
-	for _, part := range parts {
+
+	for part := range strings.SplitSeq(strings.TrimPrefix(s, vPrefix), ".") {
 		num, err := strconv.Atoi(part)
 		if err != nil {
 			return nil, fmt.Errorf("failed to parse version %q: %w", s, err)

scripts/website/dump_info/main.go

@@ -150,7 +150,7 @@ func saveCLIHelp(dst string) error {
 		return fmt.Errorf("can't run linters cmd: %w", err)
 	}
 
-	lintersOutParts := bytes.Split(lintersOut, []byte("\n\n"))
+	lintersOutEnable, _, _ := bytes.Cut(lintersOut, []byte("\n\n"))
 
 	rumCmdHelp, err := getCmdHelp("run")
 	if err != nil {
@@ -163,7 +163,7 @@ func saveCLIHelp(dst string) error {
 	}
 
 	data := types.CLIHelp{
-		Enable:     string(lintersOutParts[0]),
+		Enable:     string(lintersOutEnable),
 		RunCmdHelp: rumCmdHelp,
 		FmtCmdHelp: fmtCmdHelp,
 	}

test/bench/bench_test.go

@@ -35,15 +35,6 @@ type metrics struct {
 }
 
 func Benchmark_linters(b *testing.B) {
-	savedWD, err := os.Getwd()
-	require.NoError(b, err)
-
-	b.Cleanup(func() {
-		// Restore WD to avoid side effects when during all the benchmarks.
-		err = os.Chdir(savedWD)
-		require.NoError(b, err)
-	})
-
 	installGolangCILint(b)
 
 	repos := getAllRepositories(b)
@@ -65,8 +56,7 @@ func Benchmark_linters(b *testing.B) {
 				b.Run(repo.name, func(b *testing.B) {
 					_ = exec.Command(binName, "cache", "clean").Run()
 
-					err = os.Chdir(repo.dir)
-					require.NoErrorf(b, err, "can't chdir to %s", repo.dir)
+					b.Chdir(repo.dir)
 
 					lc := countGoLines(b)
 
@@ -83,15 +73,6 @@ func Benchmark_linters(b *testing.B) {
 }
 
 func Benchmark_golangciLint(b *testing.B) {
-	savedWD, err := os.Getwd()
-	require.NoError(b, err)
-
-	b.Cleanup(func() {
-		// Restore WD to avoid side effects when during all the benchmarks.
-		err = os.Chdir(savedWD)
-		require.NoError(b, err)
-	})
-
 	installGolangCILint(b)
 
 	_ = exec.Command(binName, "cache", "clean").Run()
@@ -114,8 +95,7 @@ func Benchmark_golangciLint(b *testing.B) {
 
 	for _, c := range cases {
 		b.Run(c.name, func(b *testing.B) {
-			err = os.Chdir(c.dir)
-			require.NoErrorf(b, err, "can't chdir to %s", c.dir)
+			b.Chdir(c.dir)
 
 			lc := countGoLines(b)
 
@@ -142,26 +122,26 @@ func getAllRepositories(tb testing.TB) []repo {
 			name: "golangci/golangci-lint",
 			dir:  cloneGithubProject(tb, benchRoot, "golangci", "golangci-lint"),
 		},
-		{
-			name: "goreleaser/goreleaser",
-			dir:  cloneGithubProject(tb, benchRoot, "goreleaser", "goreleaser"),
-		},
-		{
-			name: "gohugoio/hugo",
-			dir:  cloneGithubProject(tb, benchRoot, "gohugoio", "hugo"),
-		},
-		{
-			name: "pact-foundation/pact-go", // CGO inside
-			dir:  cloneGithubProject(tb, benchRoot, "pact-foundation", "pact-go"),
-		},
-		{
-			name: "kubernetes/kubernetes",
-			dir:  cloneGithubProject(tb, benchRoot, "kubernetes", "kubernetes"),
-		},
-		{
-			name: "moby/buildkit",
-			dir:  cloneGithubProject(tb, benchRoot, "moby", "buildkit"),
-		},
+		// {
+		// 	name: "goreleaser/goreleaser",
+		// 	dir:  cloneGithubProject(tb, benchRoot, "goreleaser", "goreleaser"),
+		// },
+		// {
+		// 	name: "gohugoio/hugo",
+		// 	dir:  cloneGithubProject(tb, benchRoot, "gohugoio", "hugo"),
+		// },
+		// {
+		// 	name: "pact-foundation/pact-go", // CGO inside
+		// 	dir:  cloneGithubProject(tb, benchRoot, "pact-foundation", "pact-go"),
+		// },
+		// {
+		// 	name: "kubernetes/kubernetes",
+		// 	dir:  cloneGithubProject(tb, benchRoot, "kubernetes", "kubernetes"),
+		// },
+		// {
+		// 	name: "moby/buildkit",
+		// 	dir:  cloneGithubProject(tb, benchRoot, "moby", "buildkit"),
+		// },
 		{
 			name: "go source code",
 			dir:  filepath.Join(build.Default.GOROOT, "src"),
@@ -236,9 +216,9 @@ func countGoLines(tb testing.TB) int {
 		tb.Fatalf("can't run go lines counter: %s", err)
 	}
 
-	parts := bytes.Split(bytes.TrimSpace(out), []byte(" "))
+	lineCount, _, _ := bytes.Cut(bytes.TrimSpace(out), []byte(" "))
 
-	n, err := strconv.Atoi(string(parts[0]))
+	n, err := strconv.Atoi(string(lineCount))
 	if err != nil {
 		tb.Log(string(out))
 		tb.Fatalf("can't parse go lines count: %s", err)
@@ -392,7 +372,14 @@ func getLinterNames(tb testing.TB, fastOnly bool) []string {
 	tb.Helper()
 
 	// add linter names here if needed.
-	var excluded []string
+	excluded := []string{
+		"gci",       // Formatter
+		"gofmt",     // Formatter
+		"gofumpt",   // Formatter
+		"goimports", // Formatter
+		"golines",   // Formatter
+		"swaggo",    // Formatter
+	}
 
 	linters, err := lintersdb.NewLinterBuilder().Build(config.NewDefault())
 	require.NoError(tb, err)
@@ -403,6 +390,10 @@ func getLinterNames(tb testing.TB, fastOnly bool) []string {
 			continue
 		}
 
+		if lc.Internal {
+			continue
+		}
+
 		if fastOnly && lc.IsSlowLinter() {
 			continue
 		}

test/testshared/integration/run.go

@@ -1,7 +1,6 @@
 package integration
 
 import (
-	"os"
 	"os/exec"
 	"path/filepath"
 	"slices"
@@ -32,12 +31,7 @@ func RunTestSourcesFromDir(t *testing.T, dir string) {
 
 	binPath := testshared.InstallGolangciLint(t)
 
-	cwd, err := os.Getwd()
-	require.NoError(t, err)
-	t.Cleanup(func() { _ = os.Chdir(cwd) })
-
-	err = os.Chdir(dir)
-	require.NoError(t, err)
+	t.Chdir(dir)
 
 	log := logutils.NewStderrLog(logutils.DebugKeyTest)
 	log.SetLevel(logutils.LogLevelInfo)