chore: remove configuration fields for commands when a command doesn't depend on the real configuration

Author: ldez

pkg/commands/config.go

@@ -17,16 +17,13 @@ type configCommand struct {
 	viper *viper.Viper
 	cmd   *cobra.Command
 
-	cfg *config.Config
-
 	log logutils.Log
 }
 
-func newConfigCommand(log logutils.Log, cfg *config.Config) *configCommand {
+func newConfigCommand(log logutils.Log) *configCommand {
 	c := &configCommand{
 		viper: viper.New(),
 		log:   log,
-		cfg:   cfg,
 	}
 
 	configCmd := &cobra.Command{
@@ -55,7 +52,9 @@ func newConfigCommand(log logutils.Log, cfg *config.Config) *configCommand {
 }
 
 func (c *configCommand) preRunE(_ *cobra.Command, _ []string) error {
-	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, config.LoaderOptions{}, c.cfg)
+	// The command doesn't depend on the real configuration.
+	// It only needs to know the path of the configuration file.
+	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, config.LoaderOptions{}, config.NewDefault())
 
 	if err := loader.Load(); err != nil {
 		return fmt.Errorf("can't load config: %w", err)

pkg/commands/help.go

@@ -17,15 +17,13 @@ import (
 type helpCommand struct {
 	cmd *cobra.Command
 
-	cfg *config.Config
-
 	dbManager *lintersdb.Manager
 
 	log logutils.Log
 }
 
-func newHelpCommand(logger logutils.Log, cfg *config.Config) *helpCommand {
-	c := &helpCommand{log: logger, cfg: cfg}
+func newHelpCommand(logger logutils.Log) *helpCommand {
+	c := &helpCommand{log: logger}
 
 	helpCmd := &cobra.Command{
 		Use:   "help",
@@ -53,7 +51,9 @@ func newHelpCommand(logger logutils.Log, cfg *config.Config) *helpCommand {
 }
 
 func (c *helpCommand) preRun(_ *cobra.Command, _ []string) {
-	c.dbManager = lintersdb.NewManager(c.cfg, c.log)
+	// The command doesn't depend on the real configuration.
+	// It just needs the list of all plugins and all presets.
+	c.dbManager = lintersdb.NewManager(config.NewDefault(), c.log)
 }
 
 func (c *helpCommand) execute(_ *cobra.Command, _ []string) {

pkg/commands/root.go

@@ -64,11 +64,11 @@ func newRootCommand(info BuildInfo) *rootCommand {
 		newLintersCommand(log, config.NewDefault()).cmd,
 		newRunCommand(log, config.NewDefault(), reportData, info).cmd,
 		newCacheCommand().cmd,
-		newConfigCommand(log, config.NewDefault()).cmd,
+		newConfigCommand(log).cmd,
 		newVersionCommand(info).cmd,
 	)
 
-	rootCmd.SetHelpCommand(newHelpCommand(log, config.NewDefault()).cmd)
+	rootCmd.SetHelpCommand(newHelpCommand(log).cmd)
 
 	c.log = log
 	c.cmd = rootCmd