contextcheck: bump to v1.0.5 && add noCache flag

Author: sylvia7788

go.mod

@@ -83,7 +83,7 @@ require (
 	github.com/spf13/viper v1.10.1
 	github.com/ssgreg/nlreturn/v2 v2.2.1
 	github.com/stretchr/testify v1.7.0
-	github.com/sylvia7788/contextcheck v1.0.4
+	github.com/sylvia7788/contextcheck v1.0.5
 	github.com/tdakkota/asciicheck v0.1.1
 	github.com/tetafro/godot v1.4.11
 	github.com/timakin/bodyclose v0.0.0-20210704033933-f49887972144

go.sum

@@ -5,6 +5,7 @@ import (
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+	"github.com/golangci/golangci-lint/pkg/lint/linter"
 )
 
 func NewContextCheck() *goanalysis.Linter {
@@ -14,5 +15,9 @@ func NewContextCheck() *goanalysis.Linter {
 		"check the function whether use a non-inherited context",
 		[]*analysis.Analyzer{analyzer},
 		nil,
-	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+	).WithLoadMode(goanalysis.LoadModeTypesInfo).WithNoCache().
+		WithContextSetter(func(lintCtx *linter.Context) {
+			analyzer.Run = contextcheck.NewRun(lintCtx.Packages)
+		})
+
 }

pkg/golinters/contextcheck.go

@@ -49,6 +49,7 @@ type Linter struct {
 	contextSetter           func(*linter.Context)
 	loadMode                LoadMode
 	needUseOriginalPackages bool
+	noCache                 bool
 }
 
 func NewLinter(name, desc string, analyzers []*analysis.Analyzer, cfg map[string]map[string]interface{}) *Linter {
@@ -86,6 +87,11 @@ func (lnt *Linter) WithContextSetter(cs func(*linter.Context)) *Linter {
 	return lnt
 }
 
+func (lnt *Linter) WithNoCache() *Linter {
+	lnt.noCache = true
+	return lnt
+}
+
 func (lnt *Linter) Name() string {
 	return lnt.name
 }
@@ -187,6 +193,10 @@ func (lnt *Linter) getLoadMode() LoadMode {
 	return lnt.loadMode
 }
 
+func (lnt *Linter) withoutCache() bool {
+	return lnt.noCache
+}
+
 func allFlagNames(fs *flag.FlagSet) []string {
 	var ret []string
 	fs.VisitAll(func(f *flag.Flag) {

pkg/golinters/goanalysis/linter.go

@@ -88,3 +88,12 @@ func (ml MetaLinter) getAnalyzerToLinterNameMapping() map[*analysis.Analyzer]str
 	}
 	return analyzerToLinterName
 }
+
+func (ml MetaLinter) withoutCache() bool {
+	for _, l := range ml.linters {
+		if l.withoutCache() {
+			return true
+		}
+	}
+	return false
+}

pkg/golinters/goanalysis/metalinter.go

@@ -25,6 +25,7 @@ type runAnalyzersConfig interface {
 	useOriginalPackages() bool
 	reportIssues(*linter.Context) []Issue
 	getLoadMode() LoadMode
+	withoutCache() bool
 }
 
 func runAnalyzers(cfg runAnalyzersConfig, lintCtx *linter.Context) ([]result.Issue, error) {
@@ -41,7 +42,11 @@ func runAnalyzers(cfg runAnalyzersConfig, lintCtx *linter.Context) ([]result.Iss
 		pkgs = lintCtx.OriginalPackages
 	}
 
-	issues, pkgsFromCache := loadIssuesFromCache(pkgs, lintCtx, cfg.getAnalyzers())
+	var issues []result.Issue
+	var pkgsFromCache map[*packages.Package]bool
+	if !cfg.withoutCache() {
+		issues, pkgsFromCache = loadIssuesFromCache(pkgs, lintCtx, cfg.getAnalyzers())
+	}
 	var pkgsToAnalyze []*packages.Package
 	for _, pkg := range pkgs {
 		if !pkgsFromCache[pkg] {
@@ -52,7 +57,7 @@ func runAnalyzers(cfg runAnalyzersConfig, lintCtx *linter.Context) ([]result.Iss
 	diags, errs, passToPkg := runner.run(cfg.getAnalyzers(), pkgsToAnalyze)
 
 	defer func() {
-		if len(errs) == 0 {
+		if len(errs) == 0 && !cfg.withoutCache() {
 			// If we try to save to cache even if we have compilation errors
 			// we won't see them on repeated runs.
 			saveIssuesToCache(pkgs, pkgsFromCache, issues, lintCtx, cfg.getAnalyzers())