feat: new default for relative-path-mode to cfg

Author: ldez

.golangci.next.reference.yml

@@ -4172,7 +4172,7 @@ run:
   # - `gitroot`: the paths will be relative to the git root (the parent directory of `.git`).
   # - `cfg`: the paths will be relative to the configuration file.
   # - `wd` (NOT recommended): the paths will be relative to the place where golangci-lint is run.
-  # Default: wd
+  # Default: cfg
   relative-path-mode: gomod
 
   # Exit code when at least one issue was found.

pkg/fsutils/basepath.go

@@ -25,8 +25,7 @@ func AllRelativePathModes() []string {
 
 func GetBasePath(ctx context.Context, mode, cfgDir string) (string, error) {
 	if mode == "" {
-		// TODO(ldez): v2 the default should be cfg or gomod.
-		mode = RelativePathModeWd
+		mode = RelativePathModeCfg
 	}
 
 	switch mode {

test/run_test.go

@@ -548,12 +548,12 @@ func TestPathPrefix(t *testing.T) {
 	}{
 		{
 			desc:    "empty",
-			pattern: "^testdata/withtests/",
+			pattern: "^test/testdata/withtests/",
 		},
 		{
 			desc:    "prefixed",
 			args:    []string{"--path-prefix=cool"},
-			pattern: "^cool/testdata/withtests",
+			pattern: "^cool/test/testdata/withtests",
 		},
 	}
 

test/testdata/configs/default_exclude.yml

@@ -6,3 +6,6 @@ linters:
       - std-error-handling
       - common-false-positives
       - legacy
+
+run:
+  relative-path-mode: wd

test/testdata/configs/multiple-issues-fix.yml

@@ -6,3 +6,6 @@ formatters:
   settings:
     gofumpt:
       extra-rules: true
+
+run:
+  relative-path-mode: wd

test/testdata/configs/output.yml

@@ -6,3 +6,6 @@ linters-settings:
     ignore-words:
       - langauge
       - Dialogue
+
+run:
+  relative-path-mode: wd

test/testdata/configs/path-except.yml

@@ -14,3 +14,6 @@ linters:
       - path-except: _test\.go
         linters:
           - forbidigo
+
+run:
+  relative-path-mode: wd