fix: the context Done chan should be closed when using verbose mode

ldez · ldez · commit 3b27686f42ed · 2025-02-25T02:29:11.000+01:00
diff --git a/pkg/commands/run.go b/pkg/commands/run.go
@@ -246,12 +246,14 @@ func (c *runCommand) execute(_ *cobra.Command, _ []string) {
 		}
 	}()
 
-	ctx := context.Background()
+	ctx, cancel := context.WithCancel(context.Background())
 	if c.cfg.Run.Timeout > 0 {
-		var cancel context.CancelFunc
 		ctx, cancel = context.WithTimeout(ctx, c.cfg.Run.Timeout)
-		defer cancel()
 	}
+	defer cancel()
+
+	deadline, ok := ctx.Deadline()
+	fmt.Println(deadline, ok)
 
 	if needTrackResources {
 		go watchResources(ctx, trackResourcesEndCh, c.log, c.debugf)
@@ -269,7 +271,7 @@ func (c *runCommand) execute(_ *cobra.Command, _ []string) {
 		}
 	}
 
-	c.setupExitCode(ctx)
+	// c.setupExitCode(ctx)
 }
 
 func (c *runCommand) startTracing() error {

Original file line number	Diff line number	Diff line change
`@@ -246,12 +246,14 @@ func (c runCommand) execute(_ cobra.Command, _ []string) {`
`246`	`246`	`}`
`247`	`247`	`}()`
`248`	`248`
`249`		`- ctx := context.Background()`
	`249`	`+ ctx, cancel := context.WithCancel(context.Background())`
`250`	`250`	`if c.cfg.Run.Timeout > 0 {`
`251`		`- var cancel context.CancelFunc`
`252`	`251`	`ctx, cancel = context.WithTimeout(ctx, c.cfg.Run.Timeout)`
`253`		`- defer cancel()`
`254`	`252`	`}`
	`253`	`+ defer cancel()`
	`254`	`+`
	`255`	`+ deadline, ok := ctx.Deadline()`
	`256`	`+ fmt.Println(deadline, ok)`
`255`	`257`
`256`	`258`	`if needTrackResources {`
`257`	`259`	`go watchResources(ctx, trackResourcesEndCh, c.log, c.debugf)`
`@@ -269,7 +271,7 @@ func (c runCommand) execute(_ cobra.Command, _ []string) {`
`269`	`271`	`}`
`270`	`272`	`}`
`271`	`273`
`272`		`- c.setupExitCode(ctx)`
	`274`	`+ // c.setupExitCode(ctx)`
`273`	`275`	`}`
`274`	`276`
`275`	`277`	`func (c *runCommand) startTracing() error {`