chore(fmt): drop v1 compatibility with exclude-dirs-use-default

ldez · ldez · commit 34137c9f6bb3 · 2025-03-10T14:39:56.000+01:00
diff --git a/pkg/commands/internal/migrate/migrate_formatters.go b/pkg/commands/internal/migrate/migrate_formatters.go
@@ -18,7 +18,7 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
 	}
 
 	if old.Issues.UseDefaultExcludeDirs == nil || ptr.Deref(old.Issues.UseDefaultExcludeDirs) {
-		paths = append(paths, "examples$")
+			paths = append(paths, "third_party$", "builtin$", "examples$")
 	}
 
 	paths = append(paths, toFormattersPathsFromRules(old.Issues)...)
diff --git a/pkg/goformat/runner.go b/pkg/goformat/runner.go
@@ -194,9 +194,6 @@ func skipDir(name string) bool {
 	case "vendor", "testdata", "node_modules":
 		return true
 
-	case "third_party", "builtin": // For compatibility with `exclude-dirs-use-default`.
-		return true
-
 	default:
 		return strings.HasPrefix(name, ".")
 	}

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`if old.Issues.UseDefaultExcludeDirs == nil \|\| ptr.Deref(old.Issues.UseDefaultExcludeDirs) {`
`21`		`- paths = append(paths, "examples$")`
	`21`	`+ paths = append(paths, "third_party$", "builtin$", "examples$")`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`paths = append(paths, toFormattersPathsFromRules(old.Issues)...)`
Original file line number	Diff line number	Diff line change
`@@ -194,9 +194,6 @@ func skipDir(name string) bool {`
`194`	`194`	`case "vendor", "testdata", "node_modules":`
`195`	`195`	`return true`
`196`	`196`
`197`		- case "third_party", "builtin": // For compatibility with `exclude-dirs-use-default`.
`198`		`- return true`
`199`		`-`
`200`	`197`	`default:`
`201`	`198`	`return strings.HasPrefix(name, ".")`
`202`	`199`	`}`