review

Author: ldez

pkg/commands/formatters.go

@@ -84,8 +84,8 @@ func (c *formattersCommand) execute(_ *cobra.Command, _ []string) error {
 		return fmt.Errorf("can't get enabled formatters: %w", err)
 	}
 
-	var enabledLinters []*linter.Config
-	var disabledLCs []*linter.Config
+	var enabledFormatters []*linter.Config
+	var disabledFormatters []*linter.Config
 
 	for _, lc := range c.dbManager.GetAllSupportedLinterConfigs() {
 		if lc.Internal {
@@ -97,16 +97,16 @@ func (c *formattersCommand) execute(_ *cobra.Command, _ []string) error {
 		}
 
 		if enabledLintersMap[lc.Name()] == nil {
-			disabledLCs = append(disabledLCs, lc)
+			disabledFormatters = append(disabledFormatters, lc)
 		} else {
-			enabledLinters = append(enabledLinters, lc)
+			enabledFormatters = append(enabledFormatters, lc)
 		}
 	}
 
 	color.Green("Enabled by your configuration formatters:\n")
-	printFormatters(enabledLinters)
+	printFormatters(enabledFormatters)
 	color.Red("\nDisabled by your configuration formatters:\n")
-	printFormatters(disabledLCs)
+	printFormatters(disabledFormatters)
 
 	return nil
 }

pkg/commands/help.go

@@ -47,6 +47,11 @@ func newHelpCommand(logger logutils.Log) *helpCommand {
 		PreRunE:           c.lintersPreRunE,
 	}
 
+	fsLinter := lintersCmd.Flags()
+	fsLinter.SortFlags = false // sort them as they are defined here
+
+	fsLinter.BoolVar(&c.opts.JSON, "json", false, color.GreenString("Display as JSON"))
+
 	helpCmd.AddCommand(lintersCmd)
 
 	formattersCmd := &cobra.Command{
@@ -58,12 +63,12 @@ func newHelpCommand(logger logutils.Log) *helpCommand {
 		PreRunE:           c.formattersPreRunE,
 	}
 
-	helpCmd.AddCommand(formattersCmd)
+	fsFormatter := formattersCmd.Flags()
+	fsFormatter.SortFlags = false // sort them as they are defined here
 
-	fs := lintersCmd.Flags()
-	fs.SortFlags = false // sort them as they are defined here
+	fsFormatter.BoolVar(&c.opts.JSON, "json", false, color.GreenString("Display as JSON"))
 
-	fs.BoolVar(&c.opts.JSON, "json", false, color.GreenString("Display as JSON"))
+	helpCmd.AddCommand(formattersCmd)
 
 	c.cmd = helpCmd