Skip to content

Commit 6d50fa8

Browse files
authored
Update backgroundcontext comment (#267)
1 parent cefb82f commit 6d50fa8

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.github/workflows/ci-v2.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
GO111MODULE: on
4040
run: |
4141
go get .
42-
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator --quiet
42+
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator app-engine-python-extras --quiet
4343
- name: Test gomod v2
4444
env:
4545
GO111MODULE: on
@@ -84,7 +84,7 @@ jobs:
8484
run: |
8585
go get -u -v $(go list -f '{{join .Imports "\n"}}{{"\n"}}{{join .TestImports "\n"}}' ./... | sort | uniq | grep -v appengine)
8686
go get -u google.golang.org/appengine/v2
87-
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator --quiet
87+
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator app-engine-python-extras --quiet
8888
- name: Test gopath v2
8989
working-directory: ${{env.working-directory}}
9090
run: |

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
GO111MODULE: on
3737
run: |
3838
go get .
39-
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator --quiet
39+
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator app-engine-python-extras --quiet
4040
- name: Test gomod
4141
env:
4242
GO111MODULE: on
@@ -77,7 +77,7 @@ jobs:
7777
run: |
7878
go get -u -v $(go list -f '{{join .Imports "\n"}}{{"\n"}}{{join .TestImports "\n"}}' ./... | sort | uniq | grep -v appengine)
7979
go get -u google.golang.org/appengine
80-
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator --quiet
80+
gcloud components install app-engine-python app-engine-go cloud-datastore-emulator app-engine-python-extras --quiet
8181
- name: Test gopath
8282
run: |
8383
export APPENGINE_DEV_APPSERVER=$(which dev_appserver.py)

appengine_vm.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ import (
1313
)
1414

1515
// BackgroundContext returns a context not associated with a request.
16-
// This should only be used when not servicing a request.
17-
// This only works in App Engine "flexible environment".
1816
func BackgroundContext() context.Context {
1917
return internal.BackgroundContext()
2018
}

v2/appengine.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,6 @@ func APICall(ctx context.Context, service, method string, in, out proto.Message)
135135
}
136136

137137
// BackgroundContext returns a context not associated with a request.
138-
// This should only be used when not servicing a request.
139-
// This only works in App Engine "flexible environment".
140138
func BackgroundContext() context.Context {
141139
return internal.BackgroundContext()
142140
}

0 commit comments

Comments
 (0)