Fix panic handling in DoCommit to prevent blocking on database driver panics #4423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When underlying database drivers panic during SQL operations, the
DoCommitfunction would propagate the panic unhandled, causing Insert operations to block indefinitely instead of returning proper errors. This was particularly problematic with ClickHouse when using*big.Intvalues that exceed column type limits (e.g., int128).Problem
The issue manifested in the following scenario:
*big.Intvalue larger than ClickHouse int128 capacity"math/big: buffer too small to fit value"big.nat.bytes→ ClickHouse driver →gdb.(*Core).DoCommitSolution
Added comprehensive panic recovery to the
DoCommitfunction indatabase/gdb/gdb_core_underlying.go:Benefits
Testing
Added comprehensive tests covering:
All existing tests continue to pass, ensuring no regressions.
Fixes #4372.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.