fix: Import all fields when importing a public key (#104)

The setPublicKeyResourceData function previously set the PublicKeyUser,
PublicKey, and PublicKeyReadOnlyFlag values from the terraform data
itself. While this works fine for data created with terraform, it
doesn't work when importing existing public keys. Imported keys would
have zero values for those fields, forcing a re-create. While this is
not a problem on its own, the delete part of the re-create would then
crash due to an empty username.

This fixes the import so the username and the key are imported from
Gitea's API.

Reviewed-on: https://gitea.com/gitea/terraform-provider-gitea/pulls/104
Co-authored-by: Mathieu Lemay <[email protected]>
Co-committed-by: Mathieu Lemay <[email protected]>

Author: mathieu-lemay

gitea/resource_gitea_public_key.go

@@ -90,10 +90,10 @@ func resourcePublicKeyDelete(d *schema.ResourceData, meta interface{}) (err erro
 
 func setPublicKeyResourceData(pubKey *gitea.PublicKey, d *schema.ResourceData) (err error) {
 	d.SetId(fmt.Sprintf("%d", pubKey.ID))
-	d.Set(PublicKeyUser, d.Get(PublicKeyUser).(string))
-	d.Set(PublicKey, d.Get(PublicKey).(string))
+	d.Set(PublicKeyUser, pubKey.Owner.UserName)
+	d.Set(PublicKey, pubKey.Key)
 	d.Set(PublicKeyTitle, pubKey.Title)
-	d.Set(PublicKeyReadOnlyFlag, d.Get(PublicKeyReadOnlyFlag).(bool))
+	d.Set(PublicKeyReadOnlyFlag, pubKey.ReadOnly)
 	d.Set(PublicKeyCreated, pubKey.Created)
 	d.Set(PublicKeyFingerprint, pubKey.Fingerprint)
 	d.Set(PublicKeyType, pubKey.KeyType)