Skip to content

[typo] #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

[typo] #9104

merged 1 commit into from
Nov 21, 2019

Conversation

@maicss
Copy link
Contributor

@maicss maicss commented Nov 21, 2019 •
edited
Loading

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #9104 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9104      +/-   ##
==========================================
- Coverage   41.15%   41.13%   -0.02%     
==========================================
  Files         549      549              
  Lines       71506    71506              
==========================================
- Hits        29429    29416      -13     
- Misses      38357    38371      +14     
+ Partials     3720     3719       -1
Impacted Files Coverage Δ
modules/indexer/indexer.go 44.73% <0%> (-10.53%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/process/manager.go 74.32% <0%> (-4.06%) ⬇️
models/pull_list.go 57.74% <0%> (-2.12%) ⬇️
models/error.go 32.67% <0%> (-0.6%) ⬇️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd82e40...ef58b19. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2019
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Nov 21, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2019
zeripath
zeripath approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna trust @lunny. The google translation reads a bit better too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2019
@lunny lunny merged commit 51ed4cc into go-gitea:master Nov 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maicss @codecov-io @lunny @zeripath @techknowlogick @GiteaBot