Fixed bug where team with admin privelege type doesn't get any unit attached to the team (#4719) (#4759)

adelowo · techknowlogick · commit e9def84bf2cf · 2018-08-21T15:29:25.000-04:00
diff --git a/routers/org/teams.go b/routers/org/teams.go
@@ -181,7 +181,8 @@ func NewTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
 		Description: form.Description,
 		Authorize:   models.ParseAccessMode(form.Permission),
 	}
-	if t.Authorize < models.AccessModeAdmin {
+
+	if t.Authorize < models.AccessModeOwner {
 		var units = make([]*models.TeamUnit, 0, len(form.Units))
 		for _, tp := range form.Units {
 			units = append(units, &models.TeamUnit{
@@ -270,7 +271,7 @@ func EditTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
 		}
 	}
 	t.Description = form.Description
-	if t.Authorize < models.AccessModeAdmin {
+	if t.Authorize < models.AccessModeOwner {
 		var units = make([]models.TeamUnit, 0, len(form.Units))
 		for _, tp := range form.Units {
 			units = append(units, models.TeamUnit{

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,8 @@ func NewTeamPost(ctx *context.Context, form auth.CreateTeamForm) {`
`181`	`181`	`Description: form.Description,`
`182`	`182`	`Authorize: models.ParseAccessMode(form.Permission),`
`183`	`183`	`}`
`184`		`- if t.Authorize < models.AccessModeAdmin {`
	`184`	`+`
	`185`	`+ if t.Authorize < models.AccessModeOwner {`
`185`	`186`	`var units = make([]*models.TeamUnit, 0, len(form.Units))`
`186`	`187`	`for _, tp := range form.Units {`
`187`	`188`	`units = append(units, &models.TeamUnit{`
`@@ -270,7 +271,7 @@ func EditTeamPost(ctx *context.Context, form auth.CreateTeamForm) {`
`270`	`271`	`}`
`271`	`272`	`}`
`272`	`273`	`t.Description = form.Description`
`273`		`- if t.Authorize < models.AccessModeAdmin {`
	`274`	`+ if t.Authorize < models.AccessModeOwner {`
`274`	`275`	`var units = make([]models.TeamUnit, 0, len(form.Units))`
`275`	`276`	`for _, tp := range form.Units {`
`276`	`277`	`units = append(units, models.TeamUnit{`