improve the pull list api

Author: lunny

services/convert/pull.go

@@ -342,6 +342,7 @@ func ToAPIPullRequests(ctx context.Context, baseRepo *repo_model.Repository, prs
 	apiRepo := ToRepo(ctx, baseRepo, baseRepoPerm)
 	baseBranchCache := make(map[string]*git_model.Branch)
 	apiPullRequests := make([]*api.PullRequest, 0, len(prs))
+	headGitRepoCache := make(map[int64]*git.Repository, len(prs))
 	for _, pr := range prs {
 		apiIssue := ToAPIIssue(ctx, doer, pr.Issue)
 
@@ -431,12 +432,10 @@ func ToAPIPullRequests(ctx context.Context, baseRepo *repo_model.Repository, prs
 			apiPullRequest.Head.Name = ""
 		}
 
-		var headGitRepo *git.Repository
 		if pr.HeadRepo != nil && pr.Flow == issues_model.PullRequestFlowGithub {
 			if pr.HeadRepoID == pr.BaseRepoID {
 				apiPullRequest.Head.RepoID = pr.HeadRepo.ID
 				apiPullRequest.Head.Repository = apiRepo
-				headGitRepo = gitRepo
 			} else {
 				p, err := access_model.GetUserRepoPermission(ctx, pr.HeadRepo, doer)
 				if err != nil {
@@ -446,22 +445,30 @@ func ToAPIPullRequests(ctx context.Context, baseRepo *repo_model.Repository, prs
 
 				apiPullRequest.Head.RepoID = pr.HeadRepo.ID
 				apiPullRequest.Head.Repository = ToRepo(ctx, pr.HeadRepo, p)
-
-				headGitRepo, err = gitrepo.OpenRepository(ctx, pr.HeadRepo)
-				if err != nil {
-					log.Error("OpenRepository[%s]: %v", pr.HeadRepo.RepoPath(), err)
-					return nil, err
-				}
-				defer headGitRepo.Close()
 			}
 
-			exist, err := git_model.IsBranchExist(ctx, pr.HeadRepoID, pr.HeadBranch)
-			if err != nil {
+			headBranch, err := git_model.GetBranch(ctx, pr.HeadRepoID, pr.HeadBranch)
+			if err != nil && !git_model.IsErrBranchNotExist(err) {
 				log.Error("GetBranch[%s]: %v", pr.HeadBranch, err)
 				return nil, err
 			}
 
-			if !exist {
+			if headBranch == nil || headBranch.IsDeleted {
+				var headGitRepo *git.Repository
+				if pr.HeadRepoID == pr.BaseRepoID {
+					headGitRepo = gitRepo
+				} else {
+					headGitRepo, ok = headGitRepoCache[pr.HeadRepoID]
+					if !ok {
+						headGitRepo, err = gitrepo.OpenRepository(ctx, pr.HeadRepo)
+						if err != nil {
+							log.Error("OpenRepository[%s]: %v", pr.HeadRepo.RepoPath(), err)
+							return nil, err
+						}
+						defer headGitRepo.Close()
+						headGitRepoCache[pr.HeadRepoID] = headGitRepo
+					}
+				}
 				headCommitID, err := headGitRepo.GetRefCommitID(apiPullRequest.Head.Ref)
 				if err != nil && !git.IsErrNotExist(err) {
 					log.Error("GetCommit[%s]: %v", pr.HeadBranch, err)
@@ -471,15 +478,8 @@ func ToAPIPullRequests(ctx context.Context, baseRepo *repo_model.Repository, prs
 					apiPullRequest.Head.Sha = headCommitID
 				}
 			} else {
-				commit, err := headGitRepo.GetBranchCommit(pr.HeadBranch)
-				if err != nil && !git.IsErrNotExist(err) {
-					log.Error("GetCommit[%s]: %v", pr.HeadBranch, err)
-					return nil, err
-				}
-				if err == nil {
-					apiPullRequest.Head.Ref = pr.HeadBranch
-					apiPullRequest.Head.Sha = commit.ID.String()
-				}
+				apiPullRequest.Head.Ref = pr.HeadBranch
+				apiPullRequest.Head.Sha = headBranch.CommitID
 			}
 		}