Fixed bug where team with admin privelege type doesn't get any unit attached to the team (#4719)

adelowo · techknowlogick · commit 6ca8fbd2f94a · 2018-08-21T13:02:32.000-04:00
diff --git a/routers/org/teams.go b/routers/org/teams.go
@@ -186,7 +186,8 @@ func NewTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
 		Description: form.Description,
 		Authorize:   models.ParseAccessMode(form.Permission),
 	}
-	if t.Authorize < models.AccessModeAdmin {
+
+	if t.Authorize < models.AccessModeOwner {
 		var units = make([]*models.TeamUnit, 0, len(form.Units))
 		for _, tp := range form.Units {
 			units = append(units, &models.TeamUnit{
@@ -275,7 +276,7 @@ func EditTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
 		}
 	}
 	t.Description = form.Description
-	if t.Authorize < models.AccessModeAdmin {
+	if t.Authorize < models.AccessModeOwner {
 		var units = make([]models.TeamUnit, 0, len(form.Units))
 		for _, tp := range form.Units {
 			units = append(units, models.TeamUnit{

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,8 @@ func NewTeamPost(ctx *context.Context, form auth.CreateTeamForm) {`
`186`	`186`	`Description: form.Description,`
`187`	`187`	`Authorize: models.ParseAccessMode(form.Permission),`
`188`	`188`	`}`
`189`		`- if t.Authorize < models.AccessModeAdmin {`
	`189`	`+`
	`190`	`+ if t.Authorize < models.AccessModeOwner {`
`190`	`191`	`var units = make([]*models.TeamUnit, 0, len(form.Units))`
`191`	`192`	`for _, tp := range form.Units {`
`192`	`193`	`units = append(units, &models.TeamUnit{`
`@@ -275,7 +276,7 @@ func EditTeamPost(ctx *context.Context, form auth.CreateTeamForm) {`
`275`	`276`	`}`
`276`	`277`	`}`
`277`	`278`	`t.Description = form.Description`
`278`		`- if t.Authorize < models.AccessModeAdmin {`
	`279`	`+ if t.Authorize < models.AccessModeOwner {`
`279`	`280`	`var units = make([]models.TeamUnit, 0, len(form.Units))`
`280`	`281`	`for _, tp := range form.Units {`
`281`	`282`	`units = append(units, models.TeamUnit{`