Removing Labels via EditPullRequest API (#5348)

lucienkerl · techknowlogick · commit 552014a06895 · 2018-12-01T01:05:57.000-05:00
* added the ability to provide an empty array at the EditPullRequests API to remove all labels

Signed-off-by: Lucien Kerl &lt;lucien.kerl@wuerth-it.com&gt;

* Update pull.go
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go
@@ -405,7 +405,7 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) {
 		}
 	}
 
-	if ctx.Repo.CanWrite(models.UnitTypePullRequests) && (form.Labels != nil && len(form.Labels) > 0) {
+	if ctx.Repo.CanWrite(models.UnitTypePullRequests) && form.Labels != nil {
 		labels, err := models.GetLabelsInRepoByIDs(ctx.Repo.Repository.ID, form.Labels)
 		if err != nil {
 			ctx.Error(500, "GetLabelsInRepoByIDsError", err)

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,7 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) {`
`405`	`405`	`}`
`406`	`406`	`}`
`407`	`407`
`408`		`- if ctx.Repo.CanWrite(models.UnitTypePullRequests) && (form.Labels != nil && len(form.Labels) > 0) {`
	`408`	`+ if ctx.Repo.CanWrite(models.UnitTypePullRequests) && form.Labels != nil {`
`409`	`409`	`labels, err := models.GetLabelsInRepoByIDs(ctx.Repo.Repository.ID, form.Labels)`
`410`	`410`	`if err != nil {`
`411`	`411`	`ctx.Error(500, "GetLabelsInRepoByIDsError", err)`