Fix ".Repository" in templates maps to different type on different pages

Signed-off-by: Julian Picht <[email protected]>

Author: jpicht

routers/routes/routes.go

@@ -253,6 +253,10 @@ func RegisterRoutes(m *macaron.Macaron) {
 	}
 
 	m.Use(user.GetNotificationCount)
+	m.Use(func(ctx *context.Context) {
+		ctx.Data["GlobalEnableWiki"] = setting.Repository.EnableWiki
+		ctx.Data["GlobalEnableIssues"] = setting.Repository.EnableIssues
+	})
 
 	// FIXME: not all routes need go through same middlewares.
 	// Especially some AJAX requests, we can reduce middleware number to improve performance.

templates/base/head_navbar.tmpl

@@ -10,7 +10,7 @@
 
 	{{if .IsSigned}}
 		<a class="item {{if .PageIsDashboard}}active{{end}}" href="{{AppSubUrl}}/">{{.i18n.Tr "dashboard"}}</a>
-		{{if .Repository.EnableIssues}}
+		{{if .GlobalEnableIssues}}
 			<a class="item {{if .PageIsIssues}}active{{end}}" href="{{AppSubUrl}}/issues">{{.i18n.Tr "issues"}}</a>
 		{{end}}
 		<a class="item {{if .PageIsPulls}}active{{end}}" href="{{AppSubUrl}}/pulls">{{.i18n.Tr "pull_requests"}}</a>

templates/repo/header.tmpl

@@ -55,13 +55,13 @@
 			</a>
 			{{end}}
 
-			{{if and .Repository.EnableIssues (.Permission.CanRead $.UnitTypeIssues)}}
+			{{if and .GlobalEnableIssues (.Permission.CanRead $.UnitTypeIssues)}}
 				<a class="{{if .PageIsIssueList}}active{{end}} item" href="{{.RepoLink}}/issues">
 					<i class="octicon octicon-issue-opened"></i> {{.i18n.Tr "repo.issues"}} <span class="ui {{if not .Repository.NumOpenIssues}}gray{{else}}blue{{end}} small label">{{.Repository.NumOpenIssues}}</span>
 				</a>
 			{{end}}
 
-			{{if and .Repository.EnableIssues (.Permission.CanRead $.UnitTypeExternalTracker)}}
+			{{if and .GlobalEnableIssues (.Permission.CanRead $.UnitTypeExternalTracker)}}
 				<a class="{{if .PageIsIssueList}}active{{end}} item" href="{{.RepoExternalIssuesLink}}" target="_blank" rel="noopener noreferrer">
 					<i class="octicon octicon-link-external"></i> {{.i18n.Tr "repo.issues"}} </span>
 				</a>
@@ -79,7 +79,7 @@
 			</a>
 			{{end}}
 
-			{{if and .Repository.EnableWiki (or (.Permission.CanRead $.UnitTypeWiki) (.Permission.CanRead $.UnitTypeExternalWiki))}}
+			{{if and .GlobalEnableWiki (or (.Permission.CanRead $.UnitTypeWiki) (.Permission.CanRead $.UnitTypeExternalWiki))}}
 				<a class="{{if .PageIsWiki}}active{{end}} item" href="{{.RepoLink}}/wiki" {{if (.Permission.CanRead $.UnitTypeExternalWiki)}} target="_blank" rel="noopener noreferrer" {{end}}>
 					<i class="octicon octicon-book"></i> {{.i18n.Tr "repo.wiki"}}
 				</a>

templates/repo/settings/options.tmpl

@@ -109,7 +109,7 @@
 			{{.i18n.Tr "repo.settings.advanced_settings"}}
 		</h4>
 		<div class="ui attached segment">
-			{{if and (not .Repository.EnableWiki) (not .Repository.EnableIssues) (not .Repository.CanEnablePulls)}}
+			{{if and (not .GlobalEnableWiki) (not .GlobalEnableIssues) (not .Repository.CanEnablePulls)}}
 				<div class="inline field">
 					<label>{{.i18n.Tr "repo.wiki.disabled"}}</label>
 				</div>
@@ -121,7 +121,7 @@
 					{{.CsrfTokenHtml}}
 					<input type="hidden" name="action" value="advanced">
 
-					{{if .Repository.EnableWiki}}
+					{{if .GlobalEnableWiki}}
 						{{$isWikiEnabled := or (.Repository.UnitEnabled $.UnitTypeWiki) (.Repository.UnitEnabled $.UnitTypeExternalWiki)}}
 						<div class="inline field">
 							<label>{{.i18n.Tr "repo.wiki"}}</label>
@@ -157,7 +157,7 @@
 
 					<div class="ui divider"></div>
 
-					{{if .Repository.EnableIssues}}
+					{{if .GlobalEnableIssues}}
 						{{$isIssuesEnabled := or (.Repository.UnitEnabled $.UnitTypeIssues) (.Repository.UnitEnabled $.UnitTypeExternalTracker)}}
 						<div class="inline field">
 							<label>{{.i18n.Tr "repo.issues"}}</label>