fix: 404

Author: ldez

providers/dns/f5xc/f5xc.go

@@ -113,11 +113,11 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
 
 	existingRRSet, err := d.client.GetRRSet(context.Background(), dns01.UnFqdn(authZone), d.config.GroupName, subDomain, "TXT")
 	if err != nil {
-		return err
+		return fmt.Errorf("f5xc: get RR Set: %w", err)
 	}
 
 	// New RRSet.
-	if existingRRSet.RRSet.TXTRecord == nil {
+	if existingRRSet == nil || existingRRSet.RRSet.TXTRecord == nil {
 		rrSet := internal.RRSet{
 			Description: "lego",
 			TTL:         d.config.TTL,

providers/dns/f5xc/internal/client.go

@@ -86,6 +86,11 @@ func (c *Client) GetRRSet(ctx context.Context, dnsZoneName, groupName, recordNam
 
 	err = c.do(req, result)
 	if err != nil {
+		usce := &APIError{}
+		if errors.As(err, &usce) && usce.StatusCode == http.StatusNotFound {
+			return nil, nil
+		}
+
 		return nil, err
 	}
 
@@ -148,8 +153,7 @@ func (c *Client) do(req *http.Request, result any) error {
 	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode/100 != 2 {
-		raw, _ := io.ReadAll(resp.Body)
-		return errutils.NewUnexpectedStatusCodeError(req, resp.StatusCode, raw)
+		return parseError(req, resp)
 	}
 
 	if result == nil {
@@ -192,3 +196,15 @@ func newJSONRequest(ctx context.Context, method string, endpoint *url.URL, paylo
 
 	return req, nil
 }
+
+func parseError(req *http.Request, resp *http.Response) error {
+	raw, _ := io.ReadAll(resp.Body)
+
+	apiErr := APIError{StatusCode: resp.StatusCode}
+	err := json.Unmarshal(raw, &apiErr)
+	if err != nil {
+		return errutils.NewUnexpectedStatusCodeError(req, resp.StatusCode, raw)
+	}
+
+	return &apiErr
+}

providers/dns/f5xc/internal/client_test.go

@@ -122,6 +122,15 @@ func TestClient_Get(t *testing.T) {
 	assert.Equal(t, expected, result)
 }
 
+func TestClient_Get_not_found(t *testing.T) {
+	client := setupTest(t, "GET /api/config/dns/namespaces/system/dns_zones/example.com/rrsets/groupA/www/TXT", http.StatusNotFound, "error_404.json")
+
+	result, err := client.GetRRSet(context.Background(), "example.com", "groupA", "www", "TXT")
+	require.NoError(t, err)
+
+	assert.Nil(t, result)
+}
+
 func TestClient_Get_error(t *testing.T) {
 	client := setupTest(t, "GET /api/config/dns/namespaces/system/dns_zones/example.com/rrsets/groupA/www/TXT", http.StatusBadRequest, "")
 

providers/dns/f5xc/internal/fixtures/error_404.json

@@ -0,0 +1,5 @@
+{
+  "code": 5,
+  "details": [],
+  "message": "the requested resource record was not found: (group,name,type) (acme-records,_acme-challenge,TXT)"
+}

providers/dns/f5xc/internal/types.go

@@ -1,5 +1,26 @@
 package internal
 
+import (
+	"fmt"
+	"strings"
+)
+
+type APIError struct {
+	StatusCode int      `json:"-"`
+	Code       int      `json:"code"`
+	Details    []string `json:"details"`
+	Message    string   `json:"message"`
+}
+
+func (a *APIError) Error() string {
+	var details string
+	if len(a.Details) > 0 {
+		details = " " + strings.Join(a.Details, ", ")
+	}
+
+	return fmt.Sprintf("code: %d, message: %s%s", a.Code, a.Message, details)
+}
+
 type APIRRSet struct {
 	DNSZoneName string `json:"dns_zone_name,omitempty"`
 	GroupName   string `json:"group_name,omitempty"`