Skip to content

Commit 20e22c7

Browse files
committed
fix: Resolve issue with wildcard cleanup.
1 parent 6fbf97a commit 20e22c7

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

providers/dns/metaname/metaname.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func NewDNSProviderConfig(config *Config) (*DNSProvider, error) {
8585
return &DNSProvider{config: config, client: client, records: records}, nil
8686
}
8787

88-
func (d *DNSProvider) Present(domain, _, keyAuth string) error {
88+
func (d *DNSProvider) Present(domain, token, keyAuth string) error {
8989
info := dns01.GetChallengeInfo(domain, keyAuth)
9090

9191
authZone, err := dns01.FindZoneByFqdn(info.EffectiveFQDN)
@@ -116,19 +116,15 @@ func (d *DNSProvider) Present(domain, _, keyAuth string) error {
116116
}
117117

118118
d.recordsMu.Lock()
119-
d.records[info.EffectiveFQDN] = ref
119+
d.records[token] = ref
120120
d.recordsMu.Unlock()
121121

122122
return nil
123123
}
124124

125-
func (d *DNSProvider) CleanUp(domain, _, keyAuth string) error {
125+
func (d *DNSProvider) CleanUp(domain, token, keyAuth string) error {
126126
info := dns01.GetChallengeInfo(domain, keyAuth)
127127

128-
if _, ok := d.records[info.EffectiveFQDN]; !ok {
129-
return nil
130-
}
131-
132128
authZone, err := dns01.FindZoneByFqdn(info.EffectiveFQDN)
133129
if err != nil {
134130
return fmt.Errorf("%s: could not find zone for domain %q (%s): %w", codeName, domain, info.EffectiveFQDN, err)
@@ -139,7 +135,7 @@ func (d *DNSProvider) CleanUp(domain, _, keyAuth string) error {
139135
ctx := context.Background()
140136

141137
d.recordsMu.Lock()
142-
ref, ok := d.records[info.EffectiveFQDN]
138+
ref, ok := d.records[token]
143139
d.recordsMu.Unlock()
144140

145141
if !ok {

0 commit comments

Comments
 (0)