Skip to content

Commit 5c195f7

Browse files
authored
fix: hover group consistency (#2380)
Signed-off-by: Adam Setch <[email protected]>
1 parent 0ce35cd commit 5c195f7

File tree

6 files changed

+1337
-1342
lines changed

6 files changed

+1337
-1342
lines changed

src/renderer/components/notifications/NotificationRow.tsx

Lines changed: 28 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export const NotificationRow: FC<INotificationRow> = ({
7676
return (
7777
<div
7878
className={cn(
79-
'group border-b',
79+
'group relative border-b',
8080
'pl-2.75 pr-1 py-0.75',
8181
'text-gitify-font border-gitify-notification-border hover:bg-gitify-notification-hover',
8282
(isAnimated || animateExit) &&
@@ -85,12 +85,7 @@ export const NotificationRow: FC<INotificationRow> = ({
8585
)}
8686
id={notification.id}
8787
>
88-
<Stack
89-
align="center"
90-
className="relative"
91-
direction="horizontal"
92-
gap="condensed"
93-
>
88+
<Stack align="center" direction="horizontal" gap="condensed">
9489
<Tooltip direction="e" text={notificationType}>
9590
<button type="button">
9691
<NotificationIcon
@@ -140,33 +135,33 @@ export const NotificationRow: FC<INotificationRow> = ({
140135

141136
<NotificationFooter notification={notification} />
142137
</Stack>
143-
144-
{!animateExit && (
145-
<HoverGroup bgColor="group-hover:bg-gitify-notification-hover">
146-
<HoverButton
147-
action={actionMarkAsDone}
148-
enabled={isMarkAsDoneFeatureSupported(notification.account)}
149-
icon={CheckIcon}
150-
label="Mark as done"
151-
testid="notification-mark-as-done"
152-
/>
153-
154-
<HoverButton
155-
action={actionMarkAsRead}
156-
icon={ReadIcon}
157-
label="Mark as read"
158-
testid="notification-mark-as-read"
159-
/>
160-
161-
<HoverButton
162-
action={actionUnsubscribeFromThread}
163-
icon={BellSlashIcon}
164-
label="Unsubscribe from thread"
165-
testid="notification-unsubscribe-from-thread"
166-
/>
167-
</HoverGroup>
168-
)}
169138
</Stack>
139+
140+
{!animateExit && (
141+
<HoverGroup bgColor="group-hover:bg-gitify-notification-hover">
142+
<HoverButton
143+
action={actionMarkAsDone}
144+
enabled={isMarkAsDoneFeatureSupported(notification.account)}
145+
icon={CheckIcon}
146+
label="Mark as done"
147+
testid="notification-mark-as-done"
148+
/>
149+
150+
<HoverButton
151+
action={actionMarkAsRead}
152+
icon={ReadIcon}
153+
label="Mark as read"
154+
testid="notification-mark-as-read"
155+
/>
156+
157+
<HoverButton
158+
action={actionUnsubscribeFromThread}
159+
icon={BellSlashIcon}
160+
label="Unsubscribe from thread"
161+
testid="notification-unsubscribe-from-thread"
162+
/>
163+
</HoverGroup>
164+
)}
170165
</div>
171166
);
172167
};

0 commit comments

Comments
 (0)