Merge branch 'main' into patch-3

Author: mchammer01

.devcontainer/devcontainer.json

@@ -17,7 +17,6 @@
 
 	// Install features. Type 'feature' in the VS Code command palette for a full list.
 	"features": {
-		"git-lfs": "latest",
 		"sshd": "latest"
 	 },
 
@@ -42,7 +41,7 @@
 	},
 
 	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "git lfs pull && npm ci",
+	"postCreateCommand": "npm ci",
 
 	// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
 	"remoteUser": "node"

.github/actions-scripts/enterprise-server-issue-templates/release-issue.md

@@ -101,7 +101,7 @@ This file should be automatically updated, but you can also run `script/update-e
 
 ### 🚢 🛳️ 🚢 Shipping the release branch
 
-- [ ] The megabranch creator should push the search index LFS objects for the public `github/docs` repo. The LFS objects were already pushed for the internal repo after the `sync-english-index-for-<PLAN@RELEASE>` was added to the megabranch. To push the LFS objects to the public repo:
+- [ ] Sync the search indices for the new release:
   1. First navigate to the [sync search indices workflow](https://github.com/github/docs-internal/actions/workflows/sync-search-indices.yml). 
   2. Then, to run the workflow with parameters, click on `Run workflow` button. 
   3. A modal will pop up where you will set the following inputs:

.github/actions/node-npm-setup/action.yml

@@ -0,0 +1,22 @@
+name: Node set up composite
+
+description: Will set up Node and install all packages by caching node_modules
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Cache node_modules
+      uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7
+      with:
+        path: node_modules
+        key: ${{ runner.os }}-node_modules-${{ hashFiles('package*.json') }}
+
+    - name: Setup node
+      uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
+      with:
+        node-version: '16.17.0'
+        cache: npm
+
+    - name: Install dependencies
+      shell: bash
+      run: npm install --prefer-offline --no-audit --ignore-scripts

.github/workflows/azure-preview-env-deploy.yml

@@ -91,7 +91,6 @@ jobs:
         with:
           ref: 'main'
           persist-credentials: 'false'
-          lfs: 'true'
 
       - if: ${{ env.IS_INTERNAL_BUILD == 'true' }}
         name: Check out PR code
@@ -100,10 +99,6 @@ jobs:
           ref: ${{ env.COMMIT_REF }}
           # To prevent issues with cloning early access content later
           persist-credentials: 'false'
-          lfs: 'true'
-
-      - name: Check out LFS objects
-        run: git lfs checkout
 
       - name: Get preview app info
         env:

.github/workflows/azure-prod-build-deploy.yml

@@ -127,22 +127,6 @@ jobs:
           token: ${{ secrets.DOCUBOT_REPO_PAT }}
           path: translations/ko-kr
 
-      # As of Dec 2022, we still have checked in translations into
-      # the main repo.
-      # We're going to remove that later.
-      # For now, just delete the excess directories so they don't add
-      # unnecessary weight to the container image.
-      - name: Delete old checked in translation directories (TEMPORARY)
-        run: |
-          rm -fr translations/zh-CN
-          rm -fr translations/ja-JP
-          rm -fr translations/es-ES
-          rm -fr translations/pt-BR
-          rm -fr translations/de-DE
-          rm -fr translations/fr-FR
-          rm -fr translations/ru-RU
-          rm -fr translations/ko-KR
-
       - name: 'Build and push image'
         uses: docker/build-push-action@1cb9d22b932e4832bb29793b7777ec860fc1cde0
         with:

.github/workflows/azure-staging-build-deploy.yml

@@ -65,10 +65,6 @@ jobs:
           ref: ${{ env.COMMIT_REF }}
           # To prevent issues with cloning early access content later
           persist-credentials: 'false'
-          lfs: 'true'
-
-      - name: Check out LFS objects
-        run: git lfs checkout
 
       - name: 'Set env vars'
         run: |

.github/workflows/browser-test.yml

@@ -50,11 +50,6 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
-        with:
-          lfs: true
-
-      - name: Checkout LFS objects
-        run: git lfs checkout
 
       - name: Setup Node
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516

.github/workflows/check-broken-links-github-github.yml

@@ -52,17 +52,10 @@ jobs:
           path: docs-early-access
           ref: main
 
-      - name: Setup Node
-        uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
-        with:
-          node-version: '16.17.0'
-          cache: npm
-
       - name: Merge docs-early-access repo's folders
         run: .github/actions-scripts/merge-early-access.sh
 
-      - name: Install Node.js dependencies
-        run: npm ci
+      - uses: ./.github/actions/node-npm-setup
 
       - name: Build server
         run: npm run build

.github/workflows/code-lint.yml

@@ -34,25 +34,12 @@ concurrency:
 jobs:
   lint:
     if: github.repository == 'github/docs-internal' || github.repository == 'github/docs'
-    runs-on: ubuntu-latest
+    runs-on: ${{ fromJSON('["ubuntu-latest", "ubuntu-20.04-xl"]')[github.repository == 'github/docs-internal'] }}
     steps:
       - name: Check out repo
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
 
-      - name: Cache node_modules
-        uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7
-        with:
-          path: node_modules
-          key: ${{ runner.os }}-node_modules-${{ hashFiles('package*.json') }}
-
-      - name: Setup node
-        uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
-        with:
-          node-version: '16.17.0'
-          cache: npm
-
-      - name: Install dependencies
-        run: npm install --prefer-offline --no-audit --ignore-scripts
+      - uses: ./.github/actions/node-npm-setup
 
       - name: Run linter
         run: npm run lint

.github/workflows/content-changes-table-comment.yml

@@ -75,7 +75,7 @@ jobs:
         run: .github/actions-scripts/content-changes-table-comment.js
 
       - name: Find content directory changes comment
-        uses: peter-evans/find-comment@1769778a0c5bd330272d749d12c036d65e70d39d
+        uses: peter-evans/find-comment@f4499a714d59013c74a08789b48abe4b704364a0
         id: findComment
         with:
           issue-number: ${{ github.event.pull_request.number }}