Ruby: Deprecate dependencies of deprecated predicates for clarity.

aschackmull · aschackmull · commit c84087cd1924 · 2025-02-14T14:18:20.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImpl.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImpl.qll
@@ -232,7 +232,7 @@ private predicate adjacentDefRead(
 }
 
 pragma[noinline]
-private predicate adjacentDefReadExt(
+deprecated private predicate adjacentDefReadExt(
   DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2,
   SsaInput::SourceVariable v
 ) {
@@ -256,7 +256,7 @@ private predicate adjacentDefReachesRead(
   )
 }
 
-private predicate adjacentDefReachesReadExt(
+deprecated private predicate adjacentDefReachesReadExt(
   DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2
 ) {
   exists(SsaInput::SourceVariable v | adjacentDefReadExt(def, bb1, i1, bb2, i2, v) |
@@ -281,7 +281,7 @@ private predicate adjacentDefSkipUncertainReads(
   SsaInput::variableRead(bb2, i2, _, true)
 }
 
-private predicate adjacentDefReachesUncertainReadExt(
+deprecated private predicate adjacentDefReachesUncertainReadExt(
   DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2
 ) {
   adjacentDefReachesReadExt(def, bb1, i1, bb2, i2) and

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ private predicate adjacentDefRead(`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`pragma[noinline]`
`235`		`-private predicate adjacentDefReadExt(`
	`235`	`+deprecated private predicate adjacentDefReadExt(`
`236`	`236`	`DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2,`
`237`	`237`	`SsaInput::SourceVariable v`
`238`	`238`	`) {`
`@@ -256,7 +256,7 @@ private predicate adjacentDefReachesRead(`
`256`	`256`	`)`
`257`	`257`	`}`
`258`	`258`
`259`		`-private predicate adjacentDefReachesReadExt(`
	`259`	`+deprecated private predicate adjacentDefReachesReadExt(`
`260`	`260`	`DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2`
`261`	`261`	`) {`
`262`	`262`	`exists(SsaInput::SourceVariable v \| adjacentDefReadExt(def, bb1, i1, bb2, i2, v) \|`
`@@ -281,7 +281,7 @@ private predicate adjacentDefSkipUncertainReads(`
`281`	`281`	`SsaInput::variableRead(bb2, i2, _, true)`
`282`	`282`	`}`
`283`	`283`
`284`		`-private predicate adjacentDefReachesUncertainReadExt(`
	`284`	`+deprecated private predicate adjacentDefReachesUncertainReadExt(`
`285`	`285`	`DefinitionExt def, SsaInput::BasicBlock bb1, int i1, SsaInput::BasicBlock bb2, int i2`
`286`	`286`	`) {`
`287`	`287`	`adjacentDefReachesReadExt(def, bb1, i1, bb2, i2) and`