Add child tests

Author: timfish

dev-packages/node-integration-tests/suites/pino/scenario-track.mjs

@@ -17,7 +17,18 @@ Sentry.withIsolationScope(() => {
 setTimeout(() => {
   Sentry.withIsolationScope(() => {
     Sentry.startSpan({ name: 'later' }, () => {
-      logger.error(new Error('oh no'));
+      // This child should be captured as we marked the parent logger to be tracked
+      const child = logger.child({ module: 'authentication' });
+      child.error(new Error('oh no'));
+
+      // This child should be ignored
+      const child2 = logger.child({ module: 'authentication.v2' });
+      Sentry.pinoIntegration.ignoreLogger(child2);
+      child2.error(new Error('oh no v2'));
+
+      // This should also be ignored as the parent is ignored
+      const child3 = child2.child({ module: 'authentication.v3' });
+      child3.error(new Error('oh no v3'));
     });
   });
 }, 1000);

dev-packages/node-integration-tests/suites/pino/scenario.mjs

@@ -4,7 +4,7 @@ import pino from 'pino';
 const logger = pino({ name: 'myapp' });
 
 const ignoredLogger = pino({ name: 'ignored' });
-Sentry.pinoIntegration.untrackLogger(ignoredLogger);
+Sentry.pinoIntegration.ignoreLogger(ignoredLogger);
 
 ignoredLogger.info('this will not be tracked');
 

dev-packages/node-integration-tests/suites/pino/test.ts

@@ -195,6 +195,7 @@ conditionalTest({ min: 20 })('Pino integration', () => {
                   type: 'string',
                   value: '{"more":3,"complex":"nope"}',
                 },
+                msg: { value: 'hello world', type: 'string' },
                 'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
@@ -208,6 +209,8 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               severity_number: 17,
               attributes: {
                 name: { value: 'myapp', type: 'string' },
+                module: { value: 'authentication', type: 'string' },
+                msg: { value: 'oh no', type: 'string' },
                 'pino.logger.level': { value: 50, type: 'integer' },
                 'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },

packages/node-core/src/integrations/pino.ts

@@ -203,14 +203,14 @@ interface PinoIntegrationFunction {
    *
    * @param logger A Pino logger instance.
    */
-  untrackLogger(logger: unknown): void;
+  ignoreLogger(logger: unknown): void;
 }
 
 /**
  * Integration for Pino logging library.
  * Captures Pino logs as Sentry logs and optionally captures some log levels as events.
  *
- * By default, all Pino loggers will be captured. To ignore a specific logger, use `pinoIntegration.untrackLogger(logger)`.
+ * By default, all Pino loggers will be captured. To ignore a specific logger, use `pinoIntegration.ignoreLogger(logger)`.
  *
  * If you disable automatic instrumentation with `autoInstrument: false`, you can mark specific loggers to be tracked with `pinoIntegration.trackLogger(logger)`.
  *
@@ -222,7 +222,7 @@ export const pinoIntegration = Object.assign(_pinoIntegration, {
       (logger as Pino)[SENTRY_TRACK_SYMBOL] = 'track';
     }
   },
-  untrackLogger(logger: unknown): void {
+  ignoreLogger(logger: unknown): void {
     if (logger && typeof logger === 'object' && 'levels' in logger) {
       (logger as Pino)[SENTRY_TRACK_SYMBOL] = 'ignore';
     }