Commit 090e7cc
authored
test(e2e/firebase): Fix firebase e2e test failing due to outdated rules file (#17448)
To test our firebase instrumentation, we spin up a firebase emulator
with firestore rules.
Looks like by default, the generated rules file was set to only allow
general data access for 30 days. This caused CI to suddenly fail from
Aug 17 onwards (and went unnoticed until today due to Hackweek).
Since this is just us running the emulator in a CI job, I think it's
okay to allow access unconditionally. Not sure though, so happy to think
of something else if reviewers have concerns.1 parent 3bf4a30 commit 090e7cc
File tree
1 file changed
+2
-10
lines changed- dev-packages/e2e-tests/test-applications/node-firebase
1 file changed
+2
-10
lines changedLines changed: 2 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 6 | + | |
| 7 | + | |
16 | 8 | | |
17 | 9 | | |
18 | 10 | | |
0 commit comments