Skip to content

Commit aac4678

Browse files
committed
docs: Fix typos in deployment scripts
1 parent 5678175 commit aac4678

File tree

2 files changed

+18
-20
lines changed

2 files changed

+18
-20
lines changed

docs/05-gitlab/06-deployment/android.mdx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Unity license in your CI's environment variable : `UNITY_LICENSE_CONTENT_ANDROID
66
required anymore now that images share a base image
77
[See related change](https://gitlab.com/game-ci/unity3d/merge_requests/63)_
88

9-
By default the apk is not signed and the build will use the Unity's default debug key. For _security
10-
reasons_, **you should not add your keystore to git**.
9+
By default, the apk is not signed and the build will use the Unity's default debug key. For
10+
_security reasons_, **you should not add your keystore to git**.
1111

1212
## Encode your keystore
1313

@@ -43,12 +43,12 @@ The bundle version code must be increment for each deployed build.
4343
To simplify the process, the `BUNDLE_VERSION_CODE` env var is used and set as bundle version code.
4444

4545
Currently, for gitlab, `BUNDLE_VERSION_CODE = $CI_PIPELINE_IID`.
46-
[Documentation](https://docs.gitlab.com/ee/ci/variables/predefined_variables.html)
47-
If you use another CI solution, set a CI env var incrementing for each pipeline.
46+
[Documentation](https://docs.gitlab.com/ee/ci/variables/predefined_variables.html) If you use
47+
another CI solution, set a CI env var incrementing for each pipeline.
4848

49-
### Fastlane supply (deployement)
49+
### Fastlane supply (deployment)
5050

51-
Follow [setup instructions](https://docs.fastlane.tools/actions/supply/) to get a google play
51+
Follow [setup instructions](https://docs.fastlane.tools/actions/supply/) to get a Google Play
5252
console token, then, add the content to env var `GPC_TOKEN`.
5353

5454
Uncomment the `#deploy-android` job in gitlab-ci.yml and replace `com.youcompany.yourgame` by your
@@ -72,7 +72,7 @@ gem "fastlane"
7272
and then copy the file to the current directory prior to installing the gem. eg
7373
`cp $CI_PROJECT_DIR/Gemfile .`.
7474

75-
That is the simplest way with command line but you can also make `fastlane/Fastfile` and
75+
That is the simplest way with command line, but you can also make `fastlane/Fastfile` and
7676
`fastlane/Appfile`, with the following command after building a temporary gradle project (export
7777
gradle project option in Unity build settings):
7878

docs/05-gitlab/06-deployment/ios.mdx

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,19 @@ brew install fastlane
2121
## Unity Settings
2222

2323
1. Switch target to iOS
24-
1. In `PlayerSettings -> Other Settings`
24+
2. In `PlayerSettings -> Other Settings`
2525
1. Fill the field `Signing Team ID`
26-
1. Ensure `Automatically Sign` is unchecked
27-
1. iOS Provisioning Profile
26+
2. Ensure `Automatically Sign` is unchecked
27+
3. iOS Provisioning Profile
2828
1. `ProfileID`: `match AppStore your_bundle_identifier` _Replace `your_bundle_identifier` by
2929
yours_
30-
1. `ProfileType`: `Distribution`
30+
2. `ProfileType`: `Distribution`
3131

3232
## XCode project
3333

34-
Make a first iOS build using your mac from Unity, that will create an xcode project.
35-
Ensure you target the same path as the CI.
36-
Ex: if you let `BUILD_NAME: ExampleProjectName` in `.gitlab-ci.yml`, your xcode project must be at
37-
the root of the following path: `.\Builds\iOS\ExampleProjectName\`
34+
Make a first iOS build using your mac from Unity, that will create an xcode project. Ensure you
35+
target the same path as the CI. Ex: if you let `BUILD_NAME: ExampleProjectName` in `.gitlab-ci.yml`,
36+
your xcode project must be at the root of the following path: `.\Builds\iOS\ExampleProjectName\`
3837

3938
## App on portal
4039

@@ -83,7 +82,7 @@ Note about `upload_to_testflight`: Change "Team" to your internal tester or remo
8382

8483
## Run tests locally
8584

86-
Run the following command to test the build and the deployement localy:
85+
Run the following command to test the build and the deployment locally:
8786

8887
```bash
8988
fastlane ios beta
@@ -105,8 +104,7 @@ you have to add the following files:
105104

106105
## Gitlab-runner - register your mac
107106

108-
To automate your build with gitlab, you need to setup your mac as a gitlab runner.
109-
Installation:
107+
To automate your build with gitlab, you need to setup your mac as a gitlab runner. Installation:
110108

111109
```bash
112110
sudo curl --output /usr/local/bin/gitlab-runner https://gitlab-runner-downloads.s3.amazonaws.com/latest/binaries/gitlab-runner-darwin-amd64
@@ -124,8 +122,8 @@ Go to your project gitlab page, then go to `settings` -> `CI/CD` -> `Runners` ->
124122
-> `Set up a specific Runner manually` -> take note of the token
125123

126124
[Follow these instructions](https://docs.gitlab.com/runner/register/index.html) to register your mac
127-
as a gitlab-runner for your specific project.
128-
Follow **macOS** instructions **without** sudo command for registration.
125+
as a gitlab-runner for your specific project. Follow **macOS** instructions **without** sudo command
126+
for registration.
129127

130128
- Tags: set `mac,ios`
131129
- Executor: set `shell`

0 commit comments

Comments
 (0)