fix: use is_serverless so that output is deterministic #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huttotw
changed the title
| @@ -7,6 +7,7 @@ run "valid_serverless_minimal_details" { | |||
| vpc_id = "my-vpc" | |||
| workgroup_arn = "workgroup_arn" | |||
| s3_bucket_name = "my-bucket" | |||
| is_serverless = true | |||
There was a problem hiding this comment.
Do we need to add some validation that workgroup_arn should be supplied when is_serverless is true?
|
@camphillips22 looks like we have to bump all the way to Terraform v1.9.0 in order to enable dependent variable validation, I'm hesitant to bump to such a recent version at the expense of compatibility. |
|
🎉 This PR is included in version 0.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses a new variable
is_serverlessso that the resources created by the module are deterministic.Checklist before submitting PR for review