Ensure absolute paths used in create-note command are relative to workspace

Author: riccardoferretti

packages/foam-vscode/src/dated-notes.spec.ts

@@ -242,7 +242,7 @@ Unix: \${FOAM_DATE_SECONDS_UNIX}`,
   const monthName = foamDate.toLocaleString('default', { month: 'long' });
   const day = foamDate.getDate();
   return {
-    filepath: \`/\${foamDate.getFullYear()}-\${String(foamDate.getMonth() + 1).padStart(2, '0')}-\${String(day).padStart(2, '0')}.md\`,
+    filepath: \`\${foamDate.getFullYear()}-\${String(foamDate.getMonth() + 1).padStart(2, '0')}-\${String(day).padStart(2, '0')}.md\`,
     content: \`# JS Template: \${monthName} \${day}\n\nGenerated by JavaScript template.\`
   };
 };`,

packages/foam-vscode/src/features/commands/create-note.spec.ts

@@ -229,6 +229,27 @@ describe('create-note command', () => {
       expect(error.message).toContain(`Failed to load template`); // eslint-disable-line jest/no-conditional-expect
     }
   });
+
+  it('creates a note with absolute path within the workspace', async () => {
+    await commands.executeCommand('foam-vscode.create-note', {
+      notePath: '/note-in-workspace.md',
+      text: 'hello workspace',
+    });
+    expect(window.activeTextEditor.document.getText()).toEqual(
+      'hello workspace'
+    );
+    expectSameUri(
+      window.activeTextEditor.document.uri,
+      fromVsCodeUri(workspace.workspaceFolders?.[0].uri).joinPath(
+        'note-in-workspace.md'
+      )
+    );
+    await deleteFile(
+      fromVsCodeUri(workspace.workspaceFolders?.[0].uri).joinPath(
+        'note-in-workspace.md'
+      )
+    );
+  });
 });
 
 describe('factories', () => {

packages/foam-vscode/src/services/templates.ts

@@ -319,6 +319,7 @@ export const NoteFactory = {
         }
       }
 
+      newFilePath = asAbsoluteWorkspaceUri(newFilePath, true);
       const expandedText = await resolver.resolveText(text);
       const selectedContent = findSelectionContent();
       await createDocAndFocus(