Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Commit 91e48d4

Browse files
committed
Allow null values as pipe parameters
1 parent 0d8d8d9 commit 91e48d4

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/array/merge.pipe.spec.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,21 @@ describe('MergePipe', () => {
2525
expect(result).toEqual([1, 2, 3, 4]);
2626
});
2727

28+
it('Should merge with null value', () => {
29+
const result = pipe.transform([1, 2], null);
30+
expect(result).toEqual([1, 2]);
31+
});
32+
33+
it('Should merge on null value', () => {
34+
const result = pipe.transform(null, [1, 2]);
35+
expect(result).toEqual([1, 2]);
36+
});
37+
38+
it('Should merge null values', () => {
39+
const result = pipe.transform(null, null);
40+
expect(result).toEqual([]);
41+
})
42+
2843
it('Should return an empty array', () => {
2944
expect(pipe.transform('a')).toEqual([]);
3045
expect(pipe.transform([], 'a')).toEqual([]);

src/array/merge.pipe.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import { Pipe, PipeTransform, NgModule } from '@angular/core';
2-
import { isArray, isDeepObject, unwrapDeep, deepIndexOf } from '../utils/utils';
2+
import { isArray, isDeepObject, unwrapDeep } from '../utils/utils';
33

44
@Pipe({
55
name: 'merge',
66
})
77
export class MergePipe implements PipeTransform {
88
transform(a?: any, b?: any): any {
9+
a = a === null ? [] : a;
10+
b = b === null ? [] : b;
911
if ((!isArray(a) && !isDeepObject(a)) || !isArray(b)) {
1012
return [];
1113
}

0 commit comments

Comments
 (0)