Skip to content

Commit e887746

Browse files
committed
fix(tests): correct TestBed configuration for all components
After upgrading to Angular 20 and @angular/fire 20, all tests were failing due to an incorrect TestBed configuration. The Firebase providers were being imported in the imports array instead of the providers array. This commit moves the Firebase providers to the providers array in the TestBed configuration for all components. It also adds any missing module dependencies to the imports array. With these changes, all tests now pass.
1 parent e8669cc commit e887746

File tree

6 files changed

+53
-16
lines changed

6 files changed

+53
-16
lines changed

firestore/src/app/homepage/homepage.component.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,16 @@ describe('HomepageComponent', () => {
9898
MatToolbarModule,
9999
MatIconModule,
100100
MatCardModule,
101-
provideFirebaseApp(() => initializeApp(projectConfig)),
102-
provideFirestore(() => getFirestore()),
103-
provideAuth(() => getAuth()),
104101
],
105102
declarations: [HomepageComponent, RestaurantCardComponent],
106103
providers: [{
107104
provide: HomepageFirestore,
108105
useClass: MockHomepageFirestore
109-
}]
106+
},
107+
provideFirebaseApp(() => initializeApp(projectConfig)),
108+
provideFirestore(() => getFirestore()),
109+
provideAuth(() => getAuth()),
110+
]
110111
});
111112
fixture = TestBed.createComponent(HomepageComponent);
112113
component = fixture.componentInstance;

firestore/src/app/restaurant-card/restaurant-card.component.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
*/
1616

1717
import { ComponentFixture, TestBed } from '@angular/core/testing';
18+
import { MatCardModule } from '@angular/material/card';
19+
import { MatIconModule } from '@angular/material/icon';
20+
import { RouterTestingModule } from '@angular/router/testing';
1821

1922
import { RestaurantCardComponent } from './restaurant-card.component';
2023

@@ -25,7 +28,7 @@ describe('RestaurantCardComponent', () => {
2528
beforeEach(() => {
2629
TestBed.configureTestingModule({
2730
declarations: [RestaurantCardComponent],
28-
imports: []
31+
imports: [MatCardModule, MatIconModule, RouterTestingModule]
2932
});
3033
fixture = TestBed.createComponent(RestaurantCardComponent);
3134
component = fixture.componentInstance;

firestore/src/app/restuarant-page/restuarant-page.component.spec.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ import { initializeApp, provideFirebaseApp } from '@angular/fire/app';
2323
import { projectConfig } from 'src/environments/environment.default';
2424
import { getFirestore, provideFirestore } from '@angular/fire/firestore';
2525
import { getAuth, provideAuth } from '@angular/fire/auth';
26+
import { MatToolbarModule } from '@angular/material/toolbar';
27+
import { MatIconModule } from '@angular/material/icon';
28+
import { CommonModule } from '@angular/common';
29+
import { ReviewListComponent } from '../review-list/review-list.component';
2630

2731
describe('RestuarantPageComponent', () => {
2832
let component: RestuarantPageComponent;
@@ -32,11 +36,15 @@ describe('RestuarantPageComponent', () => {
3236
TestBed.configureTestingModule({
3337
imports: [RouterTestingModule,
3438
MatDialogModule,
39+
MatToolbarModule,
40+
MatIconModule,
41+
CommonModule
42+
],
43+
declarations: [RestuarantPageComponent, ReviewListComponent],
44+
providers: [
3545
provideFirebaseApp(() => initializeApp(projectConfig)),
3646
provideFirestore(() => getFirestore()),
37-
provideAuth(() => getAuth())],
38-
declarations: [RestuarantPageComponent],
39-
providers: [
47+
provideAuth(() => getAuth()),
4048
{ provide: MAT_DIALOG_DATA, useValue: {} },
4149
{ provide: MatDialogRef, useValue: {} },
4250
]

firestore/src/app/review-list/review-list.component.spec.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ import { initializeApp, provideFirebaseApp } from '@angular/fire/app';
2121
import { projectConfig } from 'src/environments/environment.default';
2222
import { getFirestore, provideFirestore } from '@angular/fire/firestore';
2323
import { getAuth, provideAuth } from '@angular/fire/auth';
24+
import { MatDividerModule } from '@angular/material/divider';
25+
import { MatIconModule } from '@angular/material/icon';
26+
import { CommonModule } from '@angular/common';
2427

2528
describe('ReviewListComponent', () => {
2629
let component: ReviewListComponent;
@@ -29,9 +32,16 @@ describe('ReviewListComponent', () => {
2932
beforeEach(() => {
3033
TestBed.configureTestingModule({
3134
declarations: [ReviewListComponent],
32-
imports: [provideFirebaseApp(() => initializeApp(projectConfig)),
33-
provideFirestore(() => getFirestore()),
34-
provideAuth(() => getAuth())]
35+
imports: [
36+
MatDividerModule,
37+
MatIconModule,
38+
CommonModule
39+
],
40+
providers: [
41+
provideFirebaseApp(() => initializeApp(projectConfig)),
42+
provideFirestore(() => getFirestore()),
43+
provideAuth(() => getAuth())
44+
]
3545
});
3646
fixture = TestBed.createComponent(ReviewListComponent);
3747
component = fixture.componentInstance;

firestore/src/app/sign-in-modal/sign-in-modal.component.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ describe('SignInModalComponent', () => {
4343
MatFormFieldModule,
4444
FormsModule,
4545
MatInputModule,
46-
BrowserAnimationsModule,
46+
BrowserAnimationsModule],
47+
providers: [
4748
provideFirebaseApp(() => initializeApp(projectConfig)),
4849
provideFirestore(() => getFirestore()),
49-
provideAuth(() => getAuth())],
50-
providers: [
50+
provideAuth(() => getAuth()),
5151
{ provide: MAT_DIALOG_DATA, useValue: {} },
5252
{
5353
provide: MatDialogRef, useValue: {

firestore/src/app/submit-review-modal/submit-review-modal.component.spec.ts

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ import { initializeApp, provideFirebaseApp } from '@angular/fire/app';
2323
import { projectConfig } from 'src/environments/environment.default';
2424
import { getFirestore, provideFirestore } from '@angular/fire/firestore';
2525
import { getAuth, provideAuth } from '@angular/fire/auth';
26+
import { MatFormFieldModule } from '@angular/material/form-field';
27+
import { MatInputModule } from '@angular/material/input';
28+
import { MatButtonModule } from '@angular/material/button';
29+
import { FormsModule } from '@angular/forms';
30+
import { CommonModule } from '@angular/common';
31+
import { MatIconModule } from '@angular/material/icon';
32+
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
2633

2734

2835
describe('SubmitReviewModalComponent', () => {
@@ -32,10 +39,18 @@ describe('SubmitReviewModalComponent', () => {
3239
beforeEach(() => {
3340
TestBed.configureTestingModule({
3441
imports: [MatDialogModule,
42+
MatFormFieldModule,
43+
MatInputModule,
44+
MatButtonModule,
45+
FormsModule,
46+
CommonModule,
47+
MatIconModule,
48+
BrowserAnimationsModule
49+
],
50+
providers: [
3551
provideFirebaseApp(() => initializeApp(projectConfig)),
3652
provideFirestore(() => getFirestore()),
37-
provideAuth(() => getAuth())],
38-
providers: [
53+
provideAuth(() => getAuth()),
3954
{ provide: MAT_DIALOG_DATA, useValue: {} },
4055
{ provide: MatDialogRef, useValue: {} }
4156
],

0 commit comments

Comments
 (0)